Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/otlp/model] Sync model module #10919

Merged
merged 1 commit into from
Feb 15, 2022
Merged

[pkg/otlp/model] Sync model module #10919

merged 1 commit into from
Feb 15, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Feb 14, 2022

What does this PR do?

Sync pkg/otlp/model with OpenTelemetry Collector Datadog exporter code. In particular this adds changes from:

Motivation

Keep codebases synced

Describe how to QA your changes

Check that OTLP metrics with the aws.ecs.launch_type aws.ecs.launchtype attribute set to fargate don't have the hostname set.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • The appropriate team/.. label has been applied, if known.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@mx-psi mx-psi added this to the 7.35.0 milestone Feb 14, 2022
@mx-psi mx-psi added [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card and removed [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Feb 14, 2022
@mx-psi mx-psi marked this pull request as ready for review February 14, 2022 10:01
@mx-psi mx-psi requested a review from a team as a code owner February 14, 2022 10:01
@mx-psi mx-psi merged commit 0cac936 into main Feb 15, 2022
@mx-psi mx-psi deleted the mx-psi/sync-model branch February 15, 2022 13:19
@mx-psi mx-psi added the component/otlp PRs and issues related to OTLP ingest label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants