Add configcheck command #1139
Merged
Add configcheck command #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfpierre
force-pushed
the
mfpierre/config-check
branch
from
c057f81 to
0173350
Compare
hkaj
reviewed
Feb 4, 2018
There was a problem hiding this comment.
Great stuff 💯 LGTM overall, just one issue: I tried adding a check config file with invalid yaml and it didn't show in the configcheck command output. We can see it in the logs of course, but it would be nice if configcheck could outline the unmarshalling error. Here's the log output:
2018-02-04 12:42:22 UTC | INFO | (file.go:68 in Collect) | File Configuration Provider: searching for configuration files at: /etc/datadog-agent/conf.d
2018-02-04 12:42:22 UTC | WARN | (file.go:180 in collectEntry) | /etc/datadog-agent/conf.d/nginx.d/conf.yaml is not a valid config file: yaml: unmarshal errors:
line 4: cannot unmarshal !!str `:foo:ba...` into []check.ConfigRawMap
|
@hkaj I believe this is related to the bug report I submitted recently. The same issue occurs in the most recent releases too, in the check command. |
hkaj
approved these changes
Feb 5, 2018
|
and thanks for the eyes @tmcarr, we'll fix it asap. Making troubleshooting easier is a high priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a
configcheckcommand that helps investigating the current loaded/resolved configs for each config provider:Additionnally with a
-voption it can output debug info such as the warnings during resolve and the templates yet to be resolved:The output of this commande (in debug mode) is added to the flare to a
config-check.logfileMotivation
The autodiscovery is a piece of the agent where a lot of components could go wrong (template, ad identifiers, discovery...) and that's why we need a tool to give an idea of the current state of a running agent for development & debugging purposes