Add support for collect_ec2_tags and collect_security_groups options

[arbll]

What does this PR do?

Adds support for collect_ec2_tags and collect_security_groups config options.

Motivation

Avoid context churn on A5=>A6 update.

[ofek]

This should be updated too

datadog-agent/pkg/legacy/converter.go

Line 54 in b219d79

// TODO: collect_ec2_tags

[ofek]

Also, change these to True to confirm it works

datadog-agent/pkg/legacy/tests/datadog.conf

Lines 50 to 53 in b219d79

	# Collect AWS EC2 custom tags as agent tags (requires an IAM role associated with the instance)
	collect_ec2_tags: False
	# Incorporate security-groups into tags collected from AWS EC2
	# collect_security_groups: False

[olivielpeau]

@arbll if you look at the A5 logic: https://github.com/DataDog/dd-agent/blob/5.21.2/utils/cloud_metadata.py#L212-L214 it looks like the security_group_name tag is not part of the tags that are returned by the AWS API, but that we extract the tag from the instance metadata and append it to the list of tags. So we should probably do the same thing in A6 so that users who do have the collect_security_groups option enabled have the tag with A6.

What do you think?

[joshk0]

How do we specify this tag from the Docker image? In the old one, we were able to specify this: EC2_TAGS = "yes"

[arbll]

Hi @joshk0 thanks for reaching out.
You're right, setting this option using an environment variable is missing, adding to our backlog.
It should be available in 6.2