Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve check cmd output, fixes #1159 #1216

Merged
merged 2 commits into from
Feb 9, 2018
Merged

Improve check cmd output, fixes #1159 #1216

merged 2 commits into from
Feb 9, 2018

Conversation

mfpierre
Copy link
Contributor

@mfpierre mfpierre commented Feb 8, 2018

What does this PR do?

Improve the CLI output for the check command it now correctly displays relevant errors:

  • invalid config:
    screen shot 2018-02-08 at 19 51 00

  • invalid code:
    screen shot 2018-02-08 at 19 51 21

Motivation

Fix #1159 & improve troubleshooting

@mfpierre mfpierre added this to the 6.0.0-rc.1 milestone Feb 8, 2018
@mfpierre mfpierre requested a review from a team as a code owner February 8, 2018 18:53
olivielpeau
olivielpeau previously approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 💛 💚 💙 💜

@mfpierre mfpierre merged commit 2aefbaf into master Feb 9, 2018
@mfpierre mfpierre deleted the mfpierre/fix-check-run branch February 9, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivielpeau olivielpeau olivielpeau left review comments

Assignees
No one assigned
Labels
team/containers
Projects
None yet
Milestone
6.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mfpierre @olivielpeau