Fixed lines miss issue when tailing new files #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmichelet
previously approved these changes
Feb 20, 2018
olivielpeau
reviewed
Feb 20, 2018
| @@ -0,0 +1,4 @@ | |||
| --- | |||
| issues: | |||
There was a problem hiding this comment.
this should be under fixes not issues
ajacquemot
force-pushed
the
ajacquemot/logs_fix_tail_files_issue
branch
2 times, most recently
from
9e2f4a2 to
7702641
Compare
ajacquemot
force-pushed
the
ajacquemot/logs_fix_tail_files_issue
branch
from
7702641 to
5bf4ee5
Compare
olivielpeau
approved these changes
Feb 20, 2018
|
AppVeyor failure is unrelated (and we have another PR to fix it), the rest of the CI passes, going to merge this |
|
This was not ready for a merge, sorry I did. I will revert this for RC.3 if the follow-up to this isn't ready |
ajacquemot
added a commit
that referenced
this pull request
Feb 21, 2018
This reverts commit 7bd1048.
ajacquemot
added a commit
that referenced
this pull request
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tail new files discovered when scanning from the beginning instead of the end.
Motivation
Fixed lines miss issue when tailing new files
Additional Notes
This PR solve this issue