Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] add disable checks functionality. #1311

Merged
merged 2 commits into from
Feb 21, 2018
Merged

[gui] add disable checks functionality. #1311

merged 2 commits into from
Feb 21, 2018

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Feb 20, 2018

What does this PR do?

Allows disabling checks from the GUI. Raises "restart message" that clears automatically after the restart.

Motivation

Limited functionality on windows - not acceptable for GA.

Additional Notes

I have found an unexpected log message - I am not sure when this was introduced (should be easy to fix):

http: multiple response.WriteHeader calls

[gui] set restart warning message
@truthbk truthbk requested a review from a team as a code owner February 20, 2018 22:57
@truthbk truthbk added this to the 6.0.0-rc.3 milestone Feb 20, 2018
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! I'll approve it for you! :)

Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked closely at the changes but this looks good overall :)

@truthbk truthbk merged commit a754988 into master Feb 21, 2018
@truthbk truthbk deleted the jaime/disablegui branch February 21, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants