Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go1.18 #13201

Merged
merged 5 commits into from
Aug 30, 2022
Merged

Upgrade to Go1.18 #13201

merged 5 commits into from
Aug 30, 2022

Conversation

djmitche
Copy link
Contributor

What does this PR do?

Updates everything to Go1.18.5.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

General agent QA -- at this stage, running in various clusters and looking for issues.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@djmitche djmitche added the major_change Complex/large change, which significantly modifies agent behavior or could impact many agent teams label Aug 22, 2022
@djmitche djmitche added this to the 7.40.0 milestone Aug 22, 2022
@djmitche djmitche requested review from a team as code owners August 22, 2022 18:36
maycmlee
maycmlee approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs.

@djmitche djmitche force-pushed the dustin.mitchell/asc-128 branch from dbb9087 to b3004dd Compare August 24, 2022 17:19
paulcacheux
paulcacheux reviewed Aug 24, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@djmitche djmitche force-pushed the dustin.mitchell/asc-128 branch from 21c1a0c to 881940f Compare August 25, 2022 13:42
@djmitche
Copy link
Contributor Author

I didn't realize I had forgotten to mark this as "draft" - sorry!

@djmitche djmitche marked this pull request as draft August 25, 2022 14:00
@djmitche djmitche force-pushed the dustin.mitchell/asc-128 branch from 881940f to eae9a2a Compare August 25, 2022 14:16
@djmitche
Copy link
Contributor Author

It looks like the only two non-green things here were due to GitHub workers dying, not to Go1.18. One is CodeQL, which shouldn't depend on the Go version. The other is the MacOS tests, which have secretly been running Go1.18 for a day or two already without trouble. At any rate, I've re-run them both. Now it's time for review.

@djmitche djmitche marked this pull request as ready for review August 25, 2022 16:02
@paulcacheux
Copy link
Contributor

Great work thanks ! Do you plan to setup a go workspace afterwards ? https://go.dev/doc/tutorial/workspaces

@djmitche
Copy link
Contributor Author

Great work thanks ! Do you plan to setup a go workspace afterwards ? https://go.dev/doc/tutorial/workspaces

I wasn't planning on doing so myself. However, we've been discussing having each component bundle be a distinct module, in which case go workspaces might be very useful. Are you interested in digging into that idea?

@djmitche djmitche requested a review from a team as a code owner August 29, 2022 17:43
@djmitche
Temporarily disable trace-agent fuzz testing
3faaf3d 
This was not enabled before Go1.18 and appears to be failing.  It can be
fixed in a followup
@djmitche @ahmed-mez
Disable fuzz testing on windows
c038080 
Co-authored-by: Ahmed Mezghani <[email protected]>
@djmitche djmitche merged commit e6f6941 into main Aug 30, 2022
@djmitche djmitche deleted the dustin.mitchell/asc-128 branch August 30, 2022 15:05
djmitche added a commit that referenced this pull request Aug 31, 2022
@djmitche
Revert "Upgrade to Go1.18 (#13201)"
dd662ec 
This reverts commit e6f6941.

This reverts DataDog/datadog-agent-buildimages#272 as well -- to be addressed in a followup.
djmitche added a commit that referenced this pull request Sep 2, 2022
@djmitche
Revert "Upgrade to Go1.18 (#13201)"
8093f3c 
This reverts commit e6f6941.

This reverts DataDog/datadog-agent-buildimages#272 as well -- to be addressed in a followup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed-mez ahmed-mez ahmed-mez approved these changes

@BaptisteFoy BaptisteFoy BaptisteFoy approved these changes

@amenasria amenasria amenasria approved these changes

@maycmlee maycmlee maycmlee approved these changes

@ppknap ppknap ppknap approved these changes

@paulcacheux paulcacheux paulcacheux approved these changes

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

@brycekahle brycekahle brycekahle approved these changes

@gh123man gh123man gh123man approved these changes

@sgnn7 sgnn7 sgnn7 approved these changes

Assignees
No one assigned
Labels
[deprecated] team/agent-platform major_change Complex/large change, which significantly modifies agent behavior or could impact many agent teams team/agent-apm trace-agent team/agent-metrics-logs team/agent-security team/agent-shared-components team/networks team/processes
Projects
None yet
Milestone
7.40.0
Development

Successfully merging this pull request may close these issues.