(rcm) improve error reporting #13382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coignetp
approved these changes
Sep 6, 2022
BaptisteFoy
pushed a commit
that referenced
this pull request
Sep 16, 2022
BaptisteFoy
pushed a commit
that referenced
this pull request
Sep 16, 2022
10 tasks
BaptisteFoy
pushed a commit
that referenced
this pull request
Sep 16, 2022
BaptisteFoy
added a commit
that referenced
this pull request
Sep 16, 2022
* [RCM-132] Send back fetch error to backend (#13282) * Send back fetch error to backend * Fix test * (rcm) improve error reporting (#13382) * [RCM-432] fix(remote-config): Clean remote state on error & use fixed fork of go-tuf (#13517) * [RCM-432] fix(TUF): Clean remote state on TUF error * fix(go-tuf): Use fork of go-tuf for the time being. * refactor(uptane): Refactor the Update methods Co-authored-by: Paul <[email protected]> Co-authored-by: Arthur Bellal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves error reporting:
This PR also fixes a bogus warn log when the agent does not yet have a
targets.Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.