Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to deprecated python environment variables #14130

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Remove references to DD_AGENT_PY and DD_AGENT_PY_ENV as known env vars included in the flare. These two variables are not used in the agent or process agent anymore since agent 6.11.0.

Motivation

They were added in DataDog/datadog-process-agent#50 and removed in DataDog/datadog-process-agent#272

We used to use them in the bosh release but now they are not used in the agent at all.

Additional Notes

companion to DataDog/datadog-agent-boshrelease#178

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@sarah-witt sarah-witt added this to the 7.42.0 milestone Nov 1, 2022
@sarah-witt sarah-witt changed the title Remove references to deprecated python environment vars Remove references to deprecated python environment variables Nov 1, 2022
@sarah-witt sarah-witt marked this pull request as ready for review November 1, 2022 19:45
@sarah-witt sarah-witt requested review from a team as code owners November 1, 2022 19:45
@sarah-witt sarah-witt merged commit 227ec13 into main Dec 7, 2022
@sarah-witt sarah-witt deleted the sarah/remove-references-dd-py branch December 7, 2022 14:15
purple4reina pushed a commit that referenced this pull request Dec 21, 2022
* Remove references to deprecated python env vars

* Add release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants