[jmxfetch] add rmi registry ssl config option #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbll
added
documentation
changelog/no-changelog
[deprecated] team/agent-core
olivielpeau
reviewed
Oct 5, 2018
| # # java_options: "-Xmx200m -Xms50m" # Optional, Java JVM options | ||
| # # trust_store_path: /path/to/trustStore.jks # Optional, should be set if ssl is enabled | ||
| # # trust_store_password: password | ||
| # # refresh_beans: 600 # Optional (in seconds), default is 600 seconds. Sets refresh period for refreshing matching MBeans list. |
There was a problem hiding this comment.
the double # here were meaningful to reflect that the options are optional. Just pointing that out, not sure it should make sense to keep things this way
There was a problem hiding this comment.
Only host and port are really non-optional and we don't do this in most configuration so it looks inconsistent to me.
| # # refresh_beans: 600 # Optional (in seconds), default is 600 seconds. Sets refresh period for refreshing matching MBeans list. | ||
| # java_bin_path: /path/to/java # Optional, should be set if the agent cannot find your java executable | ||
| # java_options: "-Xmx200m -Xms50m" # Optional, Java JVM options | ||
| # trust_store_path: /path/to/trustStore.jks # Optional, should be set if "com.sun.management.jmxremote.ssl" is set to true. |
There was a problem hiding this comment.
is set to true on the target JVM I assume?
may require a longer explanation on what this jks file is exactly (not necessarily here though, full explanation could be on docs website)
| # key_store_path: /path/to/keyStore.jks # Optional, should be set if "com.sun.management.jmxremote.ssl.need.client.auth" is set to true. | ||
| # key_store_password: password | ||
| # rmi_registry_ssl: false # Optional, should be set to true if "com.sun.management.jmxremote.registry.ssl" is set to true. | ||
| # refresh_beans: 600 # Optional (in seconds), default is 600 seconds. Sets refresh period for refreshing matching MBeans list. | ||
| # # Decreasing this value may result in increased CPU usage. |
| # java_options: "-Xmx200m -Xms50m" # Optional, Java JVM options | ||
| # trust_store_path: /path/to/trustStore.jks # Optional, should be set if "com.sun.management.jmxremote.ssl" is set to true. | ||
| # trust_store_password: password | ||
| # key_store_path: /path/to/keyStore.jks # Optional, should be set if "com.sun.management.jmxremote.ssl.need.client.auth" is set to true. |
There was a problem hiding this comment.
same comments as for trust_store_path
olivielpeau
previously approved these changes
Oct 10, 2018
| # key_store_password: password | ||
| # rmi_registry_ssl: false # Optional, should be set to true if "com.sun.management.jmxremote.registry.ssl" is set to true on the target JVM. | ||
| # refresh_beans: 600 # Optional (in seconds), default is 600 seconds. Sets refresh period for refreshing matching MBeans list. | ||
| # # Decreasing this value may result in increased CPU usage. |
There was a problem hiding this comment.
let's indent this comment like the previous line, otherwise it looks like it applies to the option below it.
olivielpeau
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new config options introduced by DataDog/jmxfetch#185