Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect slice pre-allocation #26410

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Jun 6, 2024

What does this PR do?

Fix incorrect slice pre-allocation.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@L3n41c L3n41c added this to the 7.56.0 milestone Jun 6, 2024
@L3n41c L3n41c requested a review from a team as a code owner June 6, 2024 10:27
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 36036685 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=36036685 --os-family=ubuntu

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.91%. Comparing base (55525d9) to head (9afa6f0).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26410      +/-   ##
==========================================
+ Coverage   44.96%   50.91%   +5.95%     
==========================================
  Files        2354     1920     -434     
  Lines      272738   181916   -90822     
==========================================
- Hits       122628    92620   -30008     
+ Misses     140437    83793   -56644     
+ Partials     9673     5503    -4170     
Flag Coverage Δ
amzn_aarch64 ?
centos_x86_64 ?
ubuntu_aarch64 ?
ubuntu_x86_64 ?
windows 50.91% <ø> (?)
windows_amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2024

Regression Detector

Regression Detector Results

Run ID: 13e803a6-0bb6-4d3f-8086-ac7904de8538
Baseline: 55525d9
Comparison: 9afa6f0

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +2.39 [-2.54, +7.33]
file_tree memory utilization +0.61 [+0.52, +0.70]
uds_dogstatsd_to_api_cpu % cpu utilization +0.28 [-2.72, +3.29]
idle memory utilization +0.13 [+0.09, +0.17]
otel_to_otel_logs ingress throughput +0.06 [-0.29, +0.41]
trace_agent_msgpack ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.05, +0.04]
basic_py_check % cpu utilization -1.04 [-3.92, +1.83]
tcp_syslog_to_blackhole ingress throughput -5.18 [-25.90, +15.53]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@L3n41c
Copy link
Member Author

L3n41c commented Jun 10, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 10, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 27m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit af3b283 into main Jun 10, 2024
310 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lenaic/issue-25971_usm branch June 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] miss makezero in slice init
2 participants