[ASCII-2077] upgrade golangci-lint to a version that support module plugin #28022
Conversation
GustavoCaso
changed the title
GustavoCaso
added
changelog/no-changelog
qa/no-code-change
Regression DetectorRegression Detector ResultsRun ID: 234e1934-378d-4211-8511-d5caf793ff4e Metrics dashboard Target profiles Baseline: 3952fb4 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +2.47 | [-10.71, +15.66] | Logs |
| ➖ | idle | memory utilization | +0.58 | [+0.54, +0.61] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.46 | [-0.43, +1.36] | Logs |
| ➖ | basic_py_check | % cpu utilization | +0.36 | [-2.18, +2.91] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.14 | [-0.67, +0.95] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.57 | [-5.39, +4.25] | Logs |
| ➖ | file_tree | memory utilization | -0.58 | [-0.65, -0.50] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
GustavoCaso
changed the title
GustavoCaso
force-pushed
the
upgrade-golangci-lint
branch
from
37f7fdc to
b192792
Compare
GustavoCaso
force-pushed
the
upgrade-golangci-lint
branch
5 times, most recently
from
858c6e0 to
3b53c26
Compare
GustavoCaso
force-pushed
the
upgrade-golangci-lint
branch
from
3b53c26 to
2b1d24b
Compare
| @@ -162,7 +162,7 @@ func makeFlare(w http.ResponseWriter, r *http.Request, statusComponent status.Co | |||
| } | |||
|
|
|||
| //nolint:revive // TODO(CINT) Fix revive linter | |||
| func getConfigCheck(w http.ResponseWriter, r *http.Request, ac autodiscovery.Component) { | |||
| func getConfigCheck(w http.ResponseWriter, _ *http.Request, ac autodiscovery.Component) { | |||
| @@ -46,7 +46,7 @@ type MockProvider struct { | |||
| } | |||
|
|
|||
| //nolint:revive // TODO(AML) Fix revive linter | |||
| func (p *MockProvider) Collect(ctx context.Context) ([]integration.Config, error) { | |||
| func (p *MockProvider) Collect(_ context.Context) ([]integration.Config, error) { | |||
There was a problem hiding this comment.
Delete the TODO and also in the other 2 occurrences of this file
| @@ -72,14 +72,14 @@ func (s *dummyService) IsReady(context.Context) bool { | |||
| // HasFilter returns false | |||
| // | |||
| //nolint:revive // TODO(AML) Fix revive linter | |||
| func (s *dummyService) HasFilter(filter containers.FilterType) bool { | |||
| func (s *dummyService) HasFilter(_ containers.FilterType) bool { | |||
What does this PR do?
Upgrade golangci-lint to version 1.57.0 https://golangci-lint.run/product/changelog/#v1570
This is part of the effort of adding custom Go lang linters. We need to use a version that supports the new module plugin for writing custom linters.
If you want to have a look at a PoC that uses the module plugin system, you can! #27033
I fixed the revive warnings using custom script that uses the JSON output of
golanci-lintandrevivehttps://github.com/DataDog/experimental/pull/3532Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes