Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDM] Fix profile JSON fields #32376

Merged
merged 13 commits into from
Jan 29, 2025
Merged

[NDM] Fix profile JSON fields #32376

merged 13 commits into from
Jan 29, 2025

Conversation

dplepage-dd
Copy link
Contributor

@dplepage-dd dplepage-dd commented Dec 19, 2024

What does this PR do?

This deprecates some fields that should've been deprecated already and undeprecates some that shouldn't have been. It shouldn't affect the behavior for customers.

Motivation

We need several fields to be exposed to JSON apis that are in development.

Part of https://datadoghq.atlassian.net/browse/NDMII-2360

Describe how you validated your changes

Unit tests pass and local behavior is unchanged.

@dplepage-dd dplepage-dd added changelog/no-changelog team/network-device-monitoring qa/done QA done before merge and regressions are covered by tests labels Dec 19, 2024
@dplepage-dd dplepage-dd requested a review from a team as a code owner December 19, 2024 04:25
Copy link

cit-pr-commenter bot commented Dec 19, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 33e8984-5dab-4b41-8a44-e1a4dba23b1e

Baseline: add7d95
Comparison: c536c76
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.68 [-2.35, +3.71] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.37 [-0.10, +0.84] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.24 [-0.53, +1.01] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.12 [-0.84, +1.07] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.07 [-0.68, +0.82] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.29, +0.32] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.02] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.86, +0.77] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.95, +0.82] 1 Logs
file_tree memory utilization -0.08 [-0.14, -0.02] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.10 [-0.17, -0.02] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.13 [-0.92, +0.65] 1 Logs
quality_gate_idle_all_features memory utilization -0.40 [-0.47, -0.33] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.54 [-0.61, -0.48] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -0.65 [-1.57, +0.26] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 27, 2024

Uncompressed package size comparison

Comparison with ancestor add7d95f5fb541a2544b9658959f2cd2fbdc9aee

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 0.05MB ⚠️ 477.83MB 477.79MB 0.50MB
datadog-iot-agent-amd64-deb 0.04MB ⚠️ 93.83MB 93.79MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.04MB ⚠️ 93.90MB 93.86MB 0.50MB
datadog-iot-agent-x86_64-suse 0.04MB ⚠️ 93.90MB 93.86MB 0.50MB
datadog-iot-agent-arm64-deb 0.03MB ⚠️ 89.88MB 89.85MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.03MB ⚠️ 89.95MB 89.92MB 0.50MB
datadog-agent-amd64-deb 0.02MB ⚠️ 911.88MB 911.86MB 0.50MB
datadog-agent-x86_64-rpm 0.02MB ⚠️ 921.62MB 921.60MB 0.50MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 921.62MB 921.60MB 0.50MB
datadog-agent-arm64-deb 0.02MB ⚠️ 899.27MB 899.25MB 0.50MB
datadog-agent-aarch64-rpm 0.02MB ⚠️ 908.99MB 908.97MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 27, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54386563 --os-family=ubuntu

Note: This applies to commit c536c76

@dplepage-dd dplepage-dd requested review from a team and jedupau and removed request for a team December 28, 2024 03:44
@dplepage-dd dplepage-dd force-pushed the dpl/5-profile-tweaks branch 2 times, most recently from 1898a32 to c9da16e Compare January 29, 2025 18:33
Base automatically changed from dpl/4-clone to main January 29, 2025 20:52
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jan 29, 2025
@dplepage-dd
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 29, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-29 21:41:32 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-29 22:09:09 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 27m.


2025-01-29 22:34:17 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 091aa0c into main Jan 29, 2025
226 of 227 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dpl/5-profile-tweaks branch January 29, 2025 22:34
@github-actions github-actions bot added this to the 7.64.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/network-device-monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants