-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDM] Fix profile JSON fields #32376
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: add7d95 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_logs | % cpu utilization | +0.68 | [-2.35, +3.71] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.37 | [-0.10, +0.84] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.24 | [-0.53, +1.01] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.12 | [-0.84, +1.07] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.07 | [-0.68, +0.82] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.29, +0.32] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.01 | [-0.64, +0.63] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.03, +0.02] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.04 | [-0.86, +0.77] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.06 | [-0.95, +0.82] | 1 | Logs |
➖ | file_tree | memory utilization | -0.08 | [-0.14, -0.02] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.10 | [-0.17, -0.02] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.13 | [-0.92, +0.65] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.40 | [-0.47, -0.33] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle | memory utilization | -0.54 | [-0.61, -0.48] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.65 | [-1.57, +0.26] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
4db1e2d
to
8e50b96
Compare
559c10d
to
cb59f4f
Compare
8e50b96
to
2f1ee2c
Compare
cb59f4f
to
5eb73f1
Compare
2f1ee2c
to
1164e16
Compare
28f19d7
to
fb93723
Compare
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=54386563 --os-family=ubuntu Note: This applies to commit c536c76 |
efb9e01
to
76e47b7
Compare
fb93723
to
a9c9690
Compare
76e47b7
to
bf80e6e
Compare
a9c9690
to
c44547d
Compare
bf80e6e
to
163eb4d
Compare
c44547d
to
6d430ba
Compare
163eb4d
to
d0f22c1
Compare
6d430ba
to
d78d965
Compare
d0f22c1
to
4b927e9
Compare
d78d965
to
115f247
Compare
4b927e9
to
c0d2b1c
Compare
115f247
to
45b6003
Compare
c0d2b1c
to
169ea48
Compare
1898a32
to
c9da16e
Compare
c0ab8de
to
371c1d4
Compare
c9da16e
to
6636fde
Compare
/merge |
Devflow running:
|
What does this PR do?
This deprecates some fields that should've been deprecated already and undeprecates some that shouldn't have been. It shouldn't affect the behavior for customers.
Motivation
We need several fields to be exposed to JSON apis that are in development.
Part of https://datadoghq.atlassian.net/browse/NDMII-2360
Describe how you validated your changes
Unit tests pass and local behavior is unchanged.