[NDM] Move validation to profiledefinition

[dplepage-dd]

What does this PR do?

This moves some validation code out of the snmp check's internal package and into the shared profiledefinition package, so that it can be used by other packages.

It also adds a CLI tool to validate and normalize profiles.

Motivation

We need to be able to load and normalize profiles in code that won't live in the snmp internals.

https://datadoghq.atlassian.net/browse/NDMII-2360

Describe how you validated your changes

The check behavior doesn't change; tests pass and local agent runs are unchanged.

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2e62f76f-dbf1-4f58-9b26-2a4a727416a0

Baseline: 8903391
Comparison: 26b9452
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.73	[-1.38, +4.83]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.51	[-0.38, +1.41]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.33	[-0.45, +1.11]	1	Logs
➖	quality_gate_idle	memory utilization	+0.07	[+0.04, +0.11]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.02	[-0.83, +0.88]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.01	[-0.05, +0.08]	1	Logs bounds checks dashboard
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.01	[-0.64, +0.62]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.87, +0.85]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.30, +0.26]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.03	[-0.85, +0.79]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.05	[-0.74, +0.63]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.13	[-0.20, -0.07]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.18	[-0.65, +0.28]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.19	[-0.96, +0.59]	1	Logs
➖	file_tree	memory utilization	-0.69	[-0.75, -0.62]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[cit-pr-commenter]

Go Package Import Differences

Baseline: 8903391
Comparison: 26b9452

binary	os	arch	change
agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation
agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation
agent	windows	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation
agent	darwin	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation
agent	darwin	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation
iot-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation
iot-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation
heroku-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation
cluster-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation
cluster-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/collector/corechecks/snmp/internal/configvalidation

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54799570 --os-family=ubuntu

Note: This applies to commit 26b9452

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 8903391f9477dd9db6195d7777b3e93529c6b1b7

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	877.16MB	877.16MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	886.89MB	886.89MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	886.89MB	886.89MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	864.95MB	864.95MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	874.67MB	874.67MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	59.03MB	59.03MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.11MB	59.11MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.11MB	59.11MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.52MB	56.52MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	456.71MB	456.71MB	0.50MB
datadog-iot-agent-amd64-deb	-0.00MB	✅	94.01MB	94.01MB	0.50MB
datadog-iot-agent-x86_64-rpm	-0.00MB	✅	94.08MB	94.08MB	0.50MB
datadog-iot-agent-x86_64-suse	-0.00MB	✅	94.08MB	94.08MB	0.50MB
datadog-iot-agent-aarch64-rpm	-0.01MB	✅	90.12MB	90.13MB	0.50MB
datadog-iot-agent-arm64-deb	-0.01MB	✅	90.05MB	90.06MB	0.50MB

Decision

✅ Passed

[dplepage-dd]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-02-05 04:36:30 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 27m.

---

2025-02-05 05:08:31 UTC ℹ️ MergeQueue: This merge request was merged