Paulcacheux/var opt

[paulcacheux]

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

[cit-pr-commenter]

Go Package Import Differences

Baseline: 3c42298
Comparison: 0f0b6d5

binary	os	arch	change
cluster-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/util/lazyregexp
cluster-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/util/lazyregexp
security-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/util/lazyregexp
security-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/util/lazyregexp
security-agent	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/util/lazyregexp
system-probe	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/util/lazyregexp
system-probe	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/pkg/util/lazyregexp
system-probe	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/util/lazyregexp

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor c89955584a89f9d7c3a5dc295ed02d7cb549c774

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-x86_64-rpm	0.01MB	⚠️	938.40MB	938.39MB	0.50MB
datadog-agent-x86_64-suse	0.01MB	⚠️	938.40MB	938.39MB	0.50MB
datadog-agent-amd64-deb	0.01MB	⚠️	928.74MB	928.73MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	925.56MB	925.55MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	915.92MB	915.91MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	58.87MB	58.87MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	58.95MB	58.95MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	58.95MB	58.95MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.39MB	56.39MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	478.20MB	478.20MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	93.92MB	93.92MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	93.99MB	93.99MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	93.98MB	93.98MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	89.96MB	89.96MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	90.03MB	90.03MB	0.50MB

Decision

⚠️ Warning

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53246337 --os-family=ubuntu

Note: This applies to commit 3591a16

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 54197148-2aa7-430a-b7e2-76134e0b626a

Baseline: c899555
Comparison: 3591a16
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+3.18	[-0.05, +6.42]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.43	[-0.34, +1.21]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.09, +0.12]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.01	[-0.68, +0.71]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.84, +0.87]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.78, +0.80]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.84, +0.86]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.01	[-0.63, +0.65]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.00	[-0.74, +0.74]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.07	[-0.99, +0.86]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.28	[-0.36, -0.20]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.40	[-0.87, +0.06]	1	Logs
➖	file_tree	memory utilization	-0.43	[-0.58, -0.29]	1	Logs
➖	quality_gate_idle	memory utilization	-0.77	[-0.81, -0.73]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.86	[-0.93, -0.78]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.