-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make infra attributes compatible with OCB #33082
Conversation
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=54578436 --os-family=ubuntu Note: This applies to commit ddeb5b4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small nits about tagger initialization as well as formatting on builder-config.yaml
Also think we should update the go.mod for root and respective files to remove reference to the fake v0.0.0-0001... versions in tagger modules. could be done in this PR or done in a separate PR and merged/rebased into this one.
Looks great otherwise; nice work.
comp/otelcol/otlp/components/processor/infraattributesprocessor/common.go
Show resolved
Hide resolved
comp/otelcol/otlp/components/processor/infraattributesprocessor/factory.go
Show resolved
Hide resolved
comp/otelcol/otlp/components/processor/infraattributesprocessor/factory.go
Show resolved
Hide resolved
comp/otelcol/otlp/components/processor/infraattributesprocessor/factory_test.go
Show resolved
Hide resolved
comp/otelcol/otlp/components/processor/infraattributesprocessor/go.mod
Outdated
Show resolved
Hide resolved
wondering if the dependency updates are causing the issue with the serverless tests. they were broken on arm64 a few days ago but they fixed that and it was never failing on amd64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good as long as pipelines pass
/merge |
Devflow running:
|
What does this PR do?
Adds NewFactory for infra-attributes processor. Infra attributes processor can be used with OCB .
Motivation
Ensure all of DD owned components are OCB complaint.
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes