Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make infra attributes compatible with OCB #33082

Merged
merged 69 commits into from
Jan 31, 2025

Conversation

dineshg13
Copy link
Member

@dineshg13 dineshg13 commented Jan 17, 2025

What does this PR do?

Adds NewFactory for infra-attributes processor. Infra attributes processor can be used with OCB .

Motivation

Ensure all of DD owned components are OCB complaint.

Describe how you validated your changes

  1. Build a collector with OCB (add infra attributes processor to the manifest)
  2. Deploy collector with core agent
  3. Use infra attributes processor in the pipeline to retrieve tags from core agent

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added long review PR is complex, plan time to review it team/opentelemetry OpenTelemetry team labels Jan 17, 2025
@dineshg13 dineshg13 changed the base branch from main to dinesh.gurumurthy/OTEL-2150 January 17, 2025 20:34
@dineshg13 dineshg13 changed the base branch from dinesh.gurumurthy/OTEL-2150 to main January 17, 2025 20:36
@dineshg13 dineshg13 changed the base branch from main to dinesh.gurumurthy/OTEL-2150 January 17, 2025 20:36
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 28, 2025

Uncompressed package size comparison

Comparison with ancestor 8b33915cac7ef452687f33809838e10a72f26594

Diff per package
package diff status size ancestor threshold
datadog-iot-agent-arm64-deb 0.02MB ⚠️ 89.89MB 89.87MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.02MB ⚠️ 89.96MB 89.94MB 0.50MB
datadog-heroku-agent-amd64-deb 0.02MB ⚠️ 456.44MB 456.42MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.02MB ⚠️ 93.90MB 93.89MB 0.50MB
datadog-iot-agent-x86_64-suse 0.02MB ⚠️ 93.90MB 93.88MB 0.50MB
datadog-iot-agent-amd64-deb 0.02MB ⚠️ 93.83MB 93.82MB 0.50MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 886.92MB 886.91MB 0.50MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 886.92MB 886.91MB 0.50MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 874.69MB 874.68MB 0.50MB
datadog-agent-amd64-deb 0.01MB ⚠️ 877.18MB 877.17MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 864.97MB 864.96MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.02MB 59.02MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 28, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54578436 --os-family=ubuntu

Note: This applies to commit ddeb5b4

@dineshg13 dineshg13 marked this pull request as ready for review January 28, 2025 18:08
@dineshg13 dineshg13 requested a review from a team as a code owner January 28, 2025 18:08
@dineshg13 dineshg13 requested review from ankitpatel96 and jackgopack4 and removed request for ankitpatel96 January 28, 2025 18:08
Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nits about tagger initialization as well as formatting on builder-config.yaml
Also think we should update the go.mod for root and respective files to remove reference to the fake v0.0.0-0001... versions in tagger modules. could be done in this PR or done in a separate PR and merged/rebased into this one.

Looks great otherwise; nice work.

@jackgopack4
Copy link
Contributor

wondering if the dependency updates are causing the issue with the serverless tests. they were broken on arm64 a few days ago but they fixed that and it was never failing on amd64.

Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good as long as pipelines pass

@dineshg13
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 31, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-31 15:35:57 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-31 15:38:41 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 27m.


2025-01-31 16:57:55 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a7e58c6 into main Jan 31, 2025
250 of 251 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dinesh.gurumurthy/OTEL-2150-2 branch January 31, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants