Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTEL-2361] upgrade opentelemetry-mapping-go versions #33084

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Jan 17, 2025

What does this PR do?

Upgrade opentelemetry-mapping-go versions in Agent

Motivation

Brings in a few bug fixes (not user-facing), see https://github.com/DataDog/opentelemetry-mapping-go/blob/main/CHANGELOG.md.

Describe how you validated your changes

modified tests

@songy23 songy23 added changelog/no-changelog team/opentelemetry OpenTelemetry team qa/done QA done before merge and regressions are covered by tests labels Jan 17, 2025
@songy23 songy23 added this to the 7.63.0 milestone Jan 17, 2025
@songy23 songy23 requested a review from a team as a code owner January 17, 2025 20:53
@songy23 songy23 requested a review from liustanley January 17, 2025 20:53
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jan 17, 2025
@songy23 songy23 added dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency labels Jan 17, 2025
@songy23 songy23 removed the request for review from liustanley January 17, 2025 20:57
Copy link

Go Package Import Differences

Baseline: 6ce5f00
Comparison: f4341b1

binaryosarchchange
agentlinuxamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
agentlinuxarm64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
agentwindowsamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
agentdarwinamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
agentdarwinarm64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
iot-agentlinuxamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
iot-agentlinuxarm64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
heroku-agentlinuxamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
cluster-agentlinuxamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
cluster-agentlinuxarm64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
serverlesslinuxamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
serverlesslinuxarm64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
system-probelinuxamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
system-probelinuxarm64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
trace-agentlinuxamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
trace-agentlinuxarm64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
trace-agentwindowsamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
trace-agentdarwinamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
trace-agentdarwinarm64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0
heroku-trace-agentlinuxamd64
+1, -0
+go.opentelemetry.io/collector/semconv/v1.27.0

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 6ce5f0040cbb506031834320ae64eff47b424a57

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 914.54MB 914.54MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 924.19MB 924.18MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.95MB 58.95MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.46MB 56.46MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 478.37MB 478.37MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 90.05MB 90.05MB 0.50MB
datadog-dogstatsd-x86_64-rpm -0.00MB 59.02MB 59.02MB 0.50MB
datadog-dogstatsd-x86_64-suse -0.00MB 59.02MB 59.02MB 0.50MB
datadog-iot-agent-aarch64-rpm -0.00MB 90.12MB 90.12MB 0.50MB
datadog-iot-agent-amd64-deb -0.00MB 94.01MB 94.01MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.00MB 94.08MB 94.08MB 0.50MB
datadog-iot-agent-x86_64-suse -0.00MB 94.07MB 94.08MB 0.50MB
datadog-agent-x86_64-rpm -0.01MB 937.11MB 937.12MB 0.50MB
datadog-agent-x86_64-suse -0.01MB 937.11MB 937.12MB 0.50MB
datadog-agent-amd64-deb -0.01MB 927.45MB 927.46MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53377904 --os-family=ubuntu

Note: This applies to commit f4341b1

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 45c4adb7-c214-49cb-aa6e-5cb79857f51d

Baseline: 6ce5f00
Comparison: f4341b1
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.19 [+0.48, +1.90] 1 Logs
quality_gate_logs % cpu utilization +0.74 [-2.47, +3.95] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.71 [+0.63, +0.80] 1 Logs
quality_gate_idle_all_features memory utilization +0.28 [+0.20, +0.37] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.20 [+0.15, +0.24] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.09 [-0.70, +0.88] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.07 [-0.81, +0.96] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.84, +0.93] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.86, +0.93] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.11, +0.11] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.78, +0.77] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.62] 1 Logs
file_tree memory utilization -0.05 [-0.20, +0.10] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.19 [-0.98, +0.59] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.40 [-0.87, +0.07] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@songy23
Copy link
Member Author

songy23 commented Jan 17, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 17, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-17 21:49:40 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-17 22:18:13 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 35m.


2025-01-17 22:33:11 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

@songy23
Copy link
Member Author

songy23 commented Jan 17, 2025

/merge -c

@songy23
Copy link
Member Author

songy23 commented Jan 17, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 17, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-17 22:54:54 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-17 23:29:04 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit cb0d65b into main Jan 17, 2025
299 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/OTEL-2361 branch January 17, 2025 23:29
github-actions bot pushed a commit to sho-he/datadog-agent that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants