Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of the API key used in the fake intake #33113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hush-hush
Copy link
Member

@hush-hush hush-hush commented Jan 20, 2025

What does this PR do?

In order to keep test api key refresh we need to keep track of what API key was used for each paylaod.

Describe how you validated your changes

Running the CI is enough since this PR only add testing tools.

@hush-hush hush-hush requested review from a team as code owners January 20, 2025 11:58
@hush-hush hush-hush added changelog/no-changelog team/agent-shared-components qa/no-code-change No code change in Agent code requiring validation labels Jan 20, 2025
@github-actions github-actions bot added the medium review PR review might take time label Jan 20, 2025
@hush-hush hush-hush force-pushed the dustin.long/poc-fake-intake-api-key branch from 2898bfa to 6a5371d Compare January 20, 2025 11:59
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 20, 2025

[Fast Unit Tests Report]

On pipeline 54461479 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Jan 20, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 06b5a4c0-ccf7-47ca-8f42-98069ad57d9d

Baseline: 77e59ac
Comparison: b701725
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.73 [+0.26, +1.21] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.56 [-0.36, +1.48] 1 Logs
file_tree memory utilization +0.20 [+0.13, +0.26] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.14 [-0.82, +1.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.13 [-0.65, +0.91] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.27, +0.28] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.63, +0.63] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.78, +0.78] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-1.01, +0.93] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.06 [-1.05, +0.93] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.15 [-0.22, -0.07] 1 Logs
quality_gate_idle_all_features memory utilization -0.40 [-0.46, -0.33] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.40 [-0.43, -0.37] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.92 [-3.99, +2.14] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -1.35 [-2.15, -0.55] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@hush-hush hush-hush force-pushed the dustin.long/poc-fake-intake-api-key branch from 5d4eeae to eaed1bb Compare January 22, 2025 12:35
@hush-hush hush-hush force-pushed the dustin.long/poc-fake-intake-api-key branch from eaed1bb to b701725 Compare January 30, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants