[NPM-3751] retry network ID fetch #33330

akarpz · 2025-01-23T21:29:38Z

What does this PR do?

We routinely see the networkID fetch fail due to timeout errors. This may be due to the host starting up at the same time as the agent and the IMDS endpoint not being available yet. This PR retries the request a few times on startup before giving up.

Motivation

https://datadoghq.atlassian.net/browse/NPM-3751

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2025-01-23T21:58:28Z

Uncompressed package size comparison

Comparison with ancestor 31c3d5c28ba0f415ee673c34a2bc0efd22df6356

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-arm64-deb	0.00MB	✅	864.93MB	864.93MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	874.65MB	874.65MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	456.53MB	456.53MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	93.96MB	93.96MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	93.96MB	93.96MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	90.01MB	90.01MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	877.13MB	877.13MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	886.87MB	886.87MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	886.87MB	886.87MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	59.03MB	59.03MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.11MB	59.11MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.11MB	59.11MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.52MB	56.52MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	93.89MB	93.89MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	89.94MB	89.94MB	0.50MB

Decision

✅ Passed

agent-platform-auto-pr · 2025-01-23T22:00:25Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54775235 --os-family=ubuntu

Note: This applies to commit f261f2b

cit-pr-commenter · 2025-01-23T22:30:16Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d3975547-e40e-4dd3-a2d5-78ce6964965a

Baseline: 31c3d5c
Comparison: f261f2b
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+3.54	[+0.39, +6.68]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.29	[-0.49, +1.07]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.05	[-0.68, +0.77]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.04	[-0.82, +0.90]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.00	[-0.63, +0.64]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.93, +0.90]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.29, +0.27]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.05	[-0.95, +0.85]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.05	[-0.12, +0.02]	1	Logs
➖	file_tree	memory utilization	-0.06	[-0.13, +0.01]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.24	[-1.01, +0.54]	1	Logs
➖	quality_gate_idle	memory utilization	-0.27	[-0.30, -0.24]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.27	[-0.74, +0.19]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.37	[-0.45, -0.29]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.00	[-1.87, -0.12]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

AmitaiBl · 2025-01-30T14:59:44Z

pkg/process/checks/container.go

+		if err != nil {
+			log.Warnf("error getting network ID: %s", err)
+		}
+		c.networkID = networkID


maybe check that networkID is not empty, if the function retryGetNetworkID is erroring than the value for networkID will be ""

I ended up changing the logic around a bit

AmitaiBl · 2025-01-30T19:52:55Z

pkg/process/checks/net.go

+		)
+		time.Sleep(50 * time.Millisecond)
+	}
+	return "", fmt.Errorf("failed to get network ID after %d attempts", maxRetries)


maybe add the err here

Jakobovski · 2025-02-03T20:02:22Z

pkg/process/checks/net.go

+			maxRetries,
+			err,
+		)
+		time.Sleep(50 * time.Millisecond)


maybe do a backoff here? just multiple it by attempt number?

I dont know if 50ms is correct, seems kinda low but you know better

akarpz · 2025-02-06T16:34:36Z

/merge

dd-devflow · 2025-02-06T16:35:11Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2025-02-06 16:35:11 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

2025-02-06 17:04:33 UTC ℹ️ MergeQueue: This merge request was merged

retry network ID fetch

b57da6b

github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly team/networks labels Jan 23, 2025

akarpz added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jan 23, 2025

akarpz added this to the 7.63.0 milestone Jan 23, 2025

akarpz marked this pull request as ready for review January 23, 2025 21:30

akarpz requested review from a team as code owners January 23, 2025 21:30

akarpz requested a review from Jakobovski January 23, 2025 21:30

retry fetching networkID in various checks

d05d125

akarpz requested a review from a team as a code owner January 27, 2025 16:05

Merge branch 'main' into akarpowich/retry_network_id

dd9c2c6

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 27, 2025

AmitaiBl reviewed Jan 30, 2025

View reviewed changes

only retry during startup

8f1e6e2

github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Jan 30, 2025

docstrings and log levels

feb52b1

akarpz removed the request for review from a team January 30, 2025 17:31

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 30, 2025

AmitaiBl reviewed Jan 30, 2025

View reviewed changes

akarpz added 2 commits January 30, 2025 16:51

log error if all retries fail

fba0947

Merge branch 'main' into akarpowich/retry_network_id

773075a

akarpz requested a review from AmitaiBl February 3, 2025 19:35

Jakobovski reviewed Feb 3, 2025

View reviewed changes

retry based on attempt

f261f2b

akarpz requested a review from Jakobovski February 5, 2025 18:09

hmahmood approved these changes Feb 6, 2025

View reviewed changes

dd-mergequeue bot merged commit 2446cef into main Feb 6, 2025
314 checks passed

dd-mergequeue bot deleted the akarpowich/retry_network_id branch February 6, 2025 17:04

github-actions bot modified the milestones: 7.63.0, 7.64.0 Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NPM-3751] retry network ID fetch #33330

[NPM-3751] retry network ID fetch #33330

akarpz commented Jan 23, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 23, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 23, 2025 •

edited

Loading

cit-pr-commenter bot commented Jan 23, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

AmitaiBl Jan 30, 2025

akarpz Jan 30, 2025

AmitaiBl Jan 30, 2025

Jakobovski Feb 3, 2025

akarpz commented Feb 6, 2025

dd-devflow bot commented Feb 6, 2025 •

edited

Loading

[NPM-3751] retry network ID fetch #33330

[NPM-3751] retry network ID fetch #33330

Conversation

akarpz commented Jan 23, 2025 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Jan 23, 2025 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Jan 23, 2025 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Jan 23, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

AmitaiBl Jan 30, 2025

Choose a reason for hiding this comment

akarpz Jan 30, 2025

Choose a reason for hiding this comment

AmitaiBl Jan 30, 2025

Choose a reason for hiding this comment

Jakobovski Feb 3, 2025

Choose a reason for hiding this comment

akarpz commented Feb 6, 2025

dd-devflow bot commented Feb 6, 2025 • edited Loading

Devflow running: /merge

akarpz commented Jan 23, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 23, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 23, 2025 •

edited

Loading

cit-pr-commenter bot commented Jan 23, 2025 •

edited

Loading

dd-devflow bot commented Feb 6, 2025 •

edited

Loading

Devflow running: `/merge`