Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM-4131] Add netpath aggregator + e2e test #33416

Merged
merged 13 commits into from
Jan 30, 2025

Conversation

pimlu
Copy link
Contributor

@pimlu pimlu commented Jan 27, 2025

What does this PR do?

This PR adds an e2e test for network path as well as the prerequisites (mainly, a fakeintake aggregator for netpath).

It mocks a traceroute by setting up two veth pairs that get routed in a network namespace (implemented in fake_router_setup.sh). In that sense, it's a real traceroute it's testing against, it just comes back with the same result every time since it's a fixed network topology.

Stacked on top of [NPM-4131] Use module for network path payload

Motivation

First e2e test that properly checks the payload, also enables us to validate that traceroute functions correctly for both TCP and UDP

Describe how you validated your changes

After going through e2e setup:

aws-vault exec sso-agent-sandbox-account-admin -- inv new-e2e-tests.run --targets=github.com/DataDog/datadog-agent/test/new-e2e/tests/netpath --run=TestLocalMockTracerouteSuite

Possible Drawbacks / Trade-offs

Something is weird about the go.mod versions, I don't think this can be merged as-is and it needs some sort of fix.

Additional Notes

@pimlu pimlu added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/networks labels Jan 27, 2025
@pimlu pimlu marked this pull request as ready for review January 27, 2025 15:47
@pimlu pimlu requested review from a team as code owners January 27, 2025 15:47
@pimlu pimlu requested review from AmitaiBl and removed request for a team January 27, 2025 15:47
// on error, the flare output is in the error message
flareCommandOutput = strings.Join([]string{flareCommandOutput, err.Error()}, "\n")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the correct fix, but new-e2e was panicking here which was interfering with pulumi destroy. Let me know if this should be changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah that should help. We were aware of the issue but did not check to fix it yet.
Thanks for the fix

@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jan 27, 2025
Copy link

cit-pr-commenter bot commented Jan 27, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7ac85350-dc38-4fd8-b29c-bfcb30760961

Baseline: 88a6d21
Comparison: 3d784ff
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.14 [+1.07, +1.21] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.77 [-0.14, +1.68] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.40 [-0.39, +1.18] 1 Logs
file_tree memory utilization +0.23 [+0.17, +0.29] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.07 [-0.40, +0.53] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.87, +0.93] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.26, +0.30] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.76, +0.80] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.03, +0.03] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.90, +0.88] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.77, +0.73] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.06 [-0.93, +0.81] 1 Logs
quality_gate_idle memory utilization -0.18 [-0.24, -0.12] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.49 [-0.55, -0.43] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.38 [-5.33, +0.57] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@pimlu pimlu force-pushed the stuart.geipel/netpath-module branch from 97b51dc to 435b8f1 Compare January 27, 2025 20:42
@pimlu pimlu requested a review from a team as a code owner January 27, 2025 20:42
@pimlu pimlu requested a review from jeremy-hanna January 27, 2025 20:42
Base automatically changed from stuart.geipel/netpath-module to main January 28, 2025 16:00
@pimlu pimlu force-pushed the stuart.geipel/netpath-e2e branch from c1358cc to f625581 Compare January 28, 2025 18:03
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 29, 2025

Uncompressed package size comparison

Comparison with ancestor 88a6d21d40f8a8e858dc91709435462ef0c9cef8

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 911.86MB 911.86MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 921.60MB 921.60MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 921.60MB 921.60MB 0.50MB
datadog-agent-arm64-deb 0.00MB 899.25MB 899.25MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 908.97MB 908.97MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.79MB 477.79MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.79MB 93.79MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.86MB 93.86MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.86MB 93.86MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.85MB 89.85MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 89.92MB 89.92MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 29, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54381935 --os-family=ubuntu

Note: This applies to commit 3d784ff

@jeremy-hanna jeremy-hanna removed request for a team and jeremy-hanna January 29, 2025 15:57
pimlu added 3 commits January 29, 2025 15:35

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@pimlu pimlu force-pushed the stuart.geipel/netpath-e2e branch from 3ac99ad to 3d784ff Compare January 29, 2025 20:40
Copy link
Member

@KevinFairise2 KevinFairise2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pimlu
Copy link
Contributor Author

pimlu commented Jan 30, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 30, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-30 20:36:16 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.


2025-01-30 21:07:30 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 7d4d74f into main Jan 30, 2025
421 of 423 checks passed
@dd-mergequeue dd-mergequeue bot deleted the stuart.geipel/netpath-e2e branch January 30, 2025 21:07
@github-actions github-actions bot added this to the 7.64.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants