Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github workflow to bump integrations core #33455

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

sabrina-datadog
Copy link
Contributor

@sabrina-datadog sabrina-datadog commented Jan 28, 2025

What does this PR do?

  • add new workflow that runs every Monday and Wednesday at 4:00AM UTC
  • add new invoke task that gets HEAD commit of integrations core, create a PR and send a slack message

Motivation

BARX-787

Describe how you validated your changes

tested using the create_rc_pr.yml file by replacing the code with the pin integrations core code and running it on my branch: successful run | PR created

checked that the message is sent in slack:
image

Possible Drawbacks / Trade-offs

Additional Notes

@sabrina-datadog sabrina-datadog added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 28, 2025
@sabrina-datadog sabrina-datadog requested review from a team as code owners January 28, 2025 00:25
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 28, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 28, 2025

Uncompressed package size comparison

Comparison with ancestor e97a3a04ff17452c0a5d3f84a49f317d3ba59d21

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.00MB 938.65MB 938.65MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 938.65MB 938.65MB 0.50MB
datadog-agent-amd64-deb 0.00MB 928.91MB 928.91MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.88MB 477.88MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.87MB 93.87MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.00MB 90.00MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 925.81MB 925.81MB 0.50MB
datadog-agent-arm64-deb -0.00MB 916.09MB 916.09MB 0.50MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Jan 28, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 166902b4-004a-4717-a172-6a67def17cdb

Baseline: e97a3a0
Comparison: 095fb3a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.66 [+0.54, +0.78] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.22 [-0.66, +1.10] 1 Logs
quality_gate_idle_all_features memory utilization +0.11 [+0.06, +0.17] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.81, +0.92] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.61, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.04, +0.06] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.63, +0.64] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.29, +0.25] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.80, +0.74] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.90, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.88, +0.77] 1 Logs
quality_gate_idle memory utilization -0.17 [-0.20, -0.14] 1 Logs bounds checks dashboard
file_tree memory utilization -0.20 [-0.27, -0.14] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.22 [-0.68, +0.25] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.73 [-1.50, +0.05] 1 Logs
quality_gate_logs % cpu utilization -2.12 [-5.15, +0.91] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 28, 2025

[Fast Unit Tests Report]

On pipeline 54383963 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

.github/workflows/pin_integrations_core.yml Outdated Show resolved Hide resolved
.github/workflows/pin_integrations_core.yml Outdated Show resolved Hide resolved
tasks/release.py Outdated Show resolved Hide resolved
tasks/release.py Outdated Show resolved Hide resolved
tasks/release.py Outdated Show resolved Hide resolved
tasks/release.py Outdated Show resolved Hide resolved
tasks/release.py Show resolved Hide resolved
tasks/release.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 28, 2025
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comments ;)

@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 28, 2025
@sabrina-datadog sabrina-datadog requested a review from a team as a code owner January 29, 2025 00:10
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two minor comments, once fixed we should be good to go!

.github/workflows/pin_integrations_core.yml Outdated Show resolved Hide resolved
tasks/libs/common/git.py Outdated Show resolved Hide resolved
@sabrina-datadog sabrina-datadog changed the title add github workflow to pin integrations core add github workflow to bump integrations core Jan 29, 2025
@sabrina-datadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 29, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-29 22:26:46 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 27m.


2025-01-29 22:51:03 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit db518f4 into main Jan 29, 2025
214 checks passed
@dd-mergequeue dd-mergequeue bot deleted the sabrina/pin-intg-core branch January 29, 2025 22:51
@github-actions github-actions bot added this to the 7.64.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants