Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-1994] downgrade ec2 tag warn log to debug #33505

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mwdd146980
Copy link
Contributor

@mwdd146980 mwdd146980 commented Jan 28, 2025

What does this PR do?

Downgrades the following log from warn to debug: log.Warnf("unable to get tags using default credentials (falling back to instance role): %s", err)

Motivation

This is quick fix to ASCII-1994. A customer is complaining that this log is being generated repeatedly and unnecessarily, which increases their log ingestion costs.

@mwdd146980 mwdd146980 requested a review from a team as a code owner January 28, 2025 20:32
@mwdd146980 mwdd146980 requested a review from misteriaud January 28, 2025 20:32
@mwdd146980 mwdd146980 changed the title downgrade ec2 tag warn log to debug [ASCII-1994] downgrade ec2 tag warn log to debug Jan 28, 2025
@github-actions github-actions bot added [deprecated] team/agent-shared-components Deprecated. Use team/agent-configuration or team/agent-runtimes labels instead. short review PR is simple enough to be reviewed quickly labels Jan 28, 2025
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54242959 --os-family=ubuntu

Note: This applies to commit d648ff8

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 67836dd0d117c246f1eb27c6b9438de4a2e0e4b7

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.00MB 938.65MB 938.65MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 938.65MB 938.65MB 0.50MB
datadog-agent-amd64-deb 0.00MB 928.91MB 928.91MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.88MB 477.88MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.87MB 93.87MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.94MB 93.94MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.00MB 90.00MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 925.81MB 925.81MB 0.50MB
datadog-agent-arm64-deb -0.00MB 916.09MB 916.09MB 0.50MB

Decision

✅ Passed

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 34832f7e-4132-457c-a225-ec59d5d0dd05

Baseline: 67836dd
Comparison: d648ff8
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.61 [+0.74, +2.48] 1 Logs
quality_gate_idle memory utilization +0.19 [+0.15, +0.23] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.09 [-0.79, +0.97] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.89, +0.92] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.28, +0.27] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.90, +0.86] 1 Logs
file_tree memory utilization -0.02 [-0.08, +0.03] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.80, +0.74] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.08 [-0.79, +0.63] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.09 [-0.55, +0.38] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.20 [-0.28, -0.13] 1 Logs
quality_gate_idle_all_features memory utilization -0.23 [-0.28, -0.18] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -1.48 [-2.28, -0.68] 1 Logs
quality_gate_logs % cpu utilization -3.07 [-6.08, -0.05] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@mwdd146980
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 29, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-29 19:05:31 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-29 19:05:51 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@mwdd146980
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jan 29, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-01-29 19:05:51 UTC ℹ️ Devflow: /remove

@mwdd146980 mwdd146980 added qa/no-code-change No code change in Agent code requiring validation changelog/no-changelog labels Jan 29, 2025
@mwdd146980
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 29, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-29 19:07:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-29 19:09:13 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 27m.


2025-01-29 19:36:39 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit cb18ab6 into main Jan 29, 2025
246 of 248 checks passed
@dd-mergequeue dd-mergequeue bot deleted the mwdd146980/downgrade-warn-log branch January 29, 2025 19:36
@github-actions github-actions bot added this to the 7.64.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-shared-components Deprecated. Use team/agent-configuration or team/agent-runtimes labels instead. qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants