Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] Fix inet_bind / inet6_bind probes #33541

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Gui774ume
Copy link
Contributor

@Gui774ume Gui774ume commented Jan 29, 2025

What does this PR do?

This PR adds the inet6_bind probes and inet_bind return probe that was mistakenly forgotten in #32350

Motivation

This is required to properly map ingress traffic to listening services.

@Gui774ume Gui774ume added changelog/no-changelog component/system-probe team/agent-security qa/done QA done before merge and regressions are covered by tests labels Jan 29, 2025
@Gui774ume Gui774ume added this to the 7.64.0 milestone Jan 29, 2025
@Gui774ume Gui774ume requested a review from a team as a code owner January 29, 2025 15:28
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 29, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 29, 2025

[Fast Unit Tests Report]

On pipeline 54461622 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 29, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54461622 --os-family=ubuntu

Note: This applies to commit 7405730

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 29, 2025

Uncompressed package size comparison

Comparison with ancestor 65e6e9f6d7525174652c48188389cd5445361262

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.03MB ⚠️ 911.88MB 911.85MB 0.50MB
datadog-agent-arm64-deb 0.03MB ⚠️ 899.27MB 899.25MB 0.50MB
datadog-agent-x86_64-rpm 0.03MB ⚠️ 921.62MB 921.59MB 0.50MB
datadog-agent-x86_64-suse 0.03MB ⚠️ 921.62MB 921.59MB 0.50MB
datadog-agent-aarch64-rpm 0.03MB ⚠️ 908.99MB 908.97MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.81MB 477.81MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.80MB 93.80MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.87MB 93.87MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.87MB 93.87MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.87MB 89.87MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 89.94MB 89.94MB 0.50MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Jan 29, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8a46f292-d584-4724-92bc-1e649932d11c

Baseline: 65e6e9f
Comparison: 7405730
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.64 [-0.31, +1.58] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.29 [-0.17, +0.76] 1 Logs
quality_gate_idle_all_features memory utilization +0.24 [+0.18, +0.30] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.20 [+0.13, +0.26] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.08 [-0.78, +0.94] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.85, +0.96] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.27, +0.31] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.76, +0.80] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.04] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.63] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.70, +0.69] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.96, +0.95] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.85, +0.72] 1 Logs
file_tree memory utilization -0.14 [-0.20, -0.07] 1 Logs
quality_gate_idle memory utilization -0.20 [-0.23, -0.16] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -3.07 [-6.07, -0.07] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 30, 2025
@Gui774ume Gui774ume changed the title [CWS] Add inet_bind return probe [CWS] Fix inet_bind / inet6_bind probes Jan 30, 2025
@Gui774ume Gui774ume force-pushed the will/fix-rethook-inet-bind branch from b7b4e26 to 8d64a10 Compare January 30, 2025 13:49
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 30, 2025
@Gui774ume Gui774ume force-pushed the will/fix-rethook-inet-bind branch from 8d64a10 to 7405730 Compare January 30, 2025 15:31
@Gui774ume Gui774ume force-pushed the will/fix-rethook-inet-bind branch from 7405730 to 4e99c4d Compare January 30, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants