Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] do not generate getter for length functions #33584

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

safchain
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@safchain safchain added changelog/no-changelog team/agent-security qa/no-code-change No code change in Agent code requiring validation labels Jan 30, 2025
@safchain safchain added this to the Triage milestone Jan 30, 2025
@safchain safchain requested a review from a team as a code owner January 30, 2025 15:06
@github-actions github-actions bot added the medium review PR review might take time label Jan 30, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 65e6e9f6d7525174652c48188389cd5445361262

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.81MB 477.81MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.80MB 93.80MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.87MB 93.87MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.87MB 93.87MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.87MB 89.87MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 89.94MB 89.94MB 0.50MB
datadog-agent-aarch64-rpm -0.05MB 908.92MB 908.97MB 0.50MB
datadog-agent-arm64-deb -0.05MB 899.20MB 899.25MB 0.50MB
datadog-agent-amd64-deb -0.05MB 911.80MB 911.85MB 0.50MB
datadog-agent-x86_64-rpm -0.05MB 921.54MB 921.59MB 0.50MB
datadog-agent-x86_64-suse -0.05MB 921.54MB 921.59MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54457696 --os-family=ubuntu

Note: This applies to commit 7b8541d

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 53e1521d-162b-4e79-9343-52aa34bbcbb9

Baseline: 65e6e9f
Comparison: 7b8541d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +2.62 [+1.68, +3.56] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.82 [+0.02, +1.63] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.74 [+0.66, +0.81] 1 Logs
quality_gate_idle memory utilization +0.46 [+0.43, +0.50] 1 Logs bounds checks dashboard
file_tree memory utilization +0.36 [+0.29, +0.42] 1 Logs
quality_gate_idle_all_features memory utilization +0.15 [+0.10, +0.21] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.10 [-0.36, +0.57] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.31, +0.31] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.03, +0.04] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.63] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.85, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.93, +0.91] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.90, +0.87] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.88, +0.83] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.10 [-0.88, +0.68] 1 Logs
quality_gate_logs % cpu utilization -0.19 [-3.24, +2.85] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@safchain
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 30, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-30 16:14:45 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.


2025-01-30 16:53:35 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5f4441f into main Jan 30, 2025
270 checks passed
@dd-mergequeue dd-mergequeue bot deleted the safchain/no-length branch January 30, 2025 16:53
@github-actions github-actions bot modified the milestones: Triage, 7.64.0 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants