fix(kubeapiserver): validate group resource strings to support groups with periods #33647
+36
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
community
team/container-platform
buraizu
approved these changes
Feb 3, 2025
releasenotes/notes/Fix-parsing-of-group-resource-strings-a0d2897fc728de26.yaml
Outdated
Show resolved
Hide resolved
…97fc728de26.yaml Co-authored-by: Bryce Eadie <[email protected]>
gabedos
added
qa/done
gabedos
approved these changes
Feb 12, 2025
|
/merge |
|
View all feedbacks in Devflow UI.
The median merge time in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the parsing of "group resource" strings when using
kubernetes_resources_annotations_as_tags/kubernetes_resources_labels_as_tagsto support groups that contain periods. The updated code uses Kubernetes' own validations to ensure that the resource and group are RFC1123-compliant Labels and Subdomains, respectively.Fixes #33646
Motivation
The current validation logic requires that the key will contain only one period, meaning it's not currently possible to specify resources whose groups contain periods as is common with CRDs.
Describe how you validated your changes
Updated tests and included additional negative tests for invalid entries.
Possible Drawbacks / Trade-offs
None known