Change bininspect.InspectWithDWARF to take dwarf data

[grantseltzer]

What does this PR do?

This moves the loading of DWARF data into memory from inside the bininspect InspectWithDWARF API to outside of it. This allows dynamic instrumentation to re-use the allocated DWARF data which would then get passed in. This should drastically reduce the size of allocations in Go DI while having no effect in the one other place where the function is used.

Motivation

Remove large allocations in the system-probe. The DWARF info was loaded twice, doubling the the size of allocation.

Describe how you validated your changes

We will check continuous profiler on nightly build.

Possible Drawbacks / Trade-offs

We can simplify the DWARF parsing code in Go DI moving everything into bininspect instead of marrying data from two separate sources.

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 55559071 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 4e8821dc6e792662f876a8b40d74fabe578fd258

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-aarch64-rpm	0.00MB	✅	863.87MB	863.87MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	875.38MB	875.38MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	875.38MB	875.38MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	865.61MB	865.61MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	854.12MB	854.12MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	59.04MB	59.04MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.12MB	59.12MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.12MB	59.12MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.53MB	56.53MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	440.97MB	440.97MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	86.36MB	86.36MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	86.43MB	86.43MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	86.42MB	86.42MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	82.62MB	82.62MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	82.69MB	82.69MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55559071 --os-family=ubuntu

Note: This applies to commit 8f40ebe

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 45b5212e-74d2-4f53-a8a8-c1378e243fa3

Baseline: 4e8821d
Comparison: 8f40ebe
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.73	[-1.35, +4.81]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.73	[+0.27, +1.20]	1	Logs
➖	quality_gate_idle	memory utilization	+0.14	[+0.10, +0.18]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.14	[-0.64, +0.91]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.04	[-0.86, +0.94]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.03	[-0.22, +0.28]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.02	[-0.76, +0.81]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.02	[-0.63, +0.66]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.01	[-0.92, +0.93]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.01	[-0.92, +0.90]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.03	[-0.82, +0.77]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.09	[-1.01, +0.83]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.10	[-0.17, -0.04]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.36	[-0.43, -0.29]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.12	[-1.19, -1.06]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[guyarb]

I'd add benchmark results to show the improvement

[grantseltzer]

Given priorities of other work I will post continuous profiler data after the fact rather than deploying a custom image now.

[GreenMatan]

Left one small comment, beyond that LGTM

[grantseltzer]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-02-10 18:53:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2025-02-10 22:54:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	837.37MiB	858.45MiB	202.88MiB	214.3MiB
✅	static_quality_gate_docker_agent_amd64	921.67MiB	942.69MiB	308.65MiB	321.56MiB
✅	static_quality_gate_docker_agent_arm64	934.04MiB	952.69MiB	292.63MiB	351.22MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.09GiB	1.11GiB	383.74MiB	395.8MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.09GiB	1.11GiB	363.72MiB	375.5MiB
✅	static_quality_gate_docker_dogstatsd_amd64	47.86MiB	57.88MiB	18.29MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	46.26MiB	56.27MiB	17.04MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	267.69MiB	277.7MiB	107.27MiB	117.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	283.73MiB	293.73MiB	102.1MiB	112.12MiB

[grantseltzer]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-02-11 18:31:45 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.

---

2025-02-11 19:14:04 UTC ℹ️ MergeQueue: This merge request was merged