Disable fentry by default in event stream #33692
Conversation
safchain
added
changelog/no-changelog
team/agent-security
qa/done
github-actions
bot
added
the
short review
Static quality checks ✅Please find below the results from static quality gates Info
|
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=54826137 --os-family=ubuntuNote: This applies to commit 31e5ecf |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 5025a79 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.64 | [+1.75, +3.54] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.83 | [+0.77, +0.90] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.58 | [+0.54, +0.61] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | +0.20 | [-2.88, +3.28] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.18 | [-0.59, +0.95] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.10 | [-0.82, +1.01] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.09 | [-0.65, +0.82] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.07 | [-0.39, +0.54] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.02 | [-0.86, +0.91] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.02 | [-0.92, +0.97] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.01 | [-0.62, +0.65] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.01, +0.03] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.00 | [-0.07, +0.08] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.00 | [-0.80, +0.79] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.28, +0.26] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.12 | [-0.19, -0.05] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
| @@ -381,7 +381,7 @@ func InitSystemProbeConfig(cfg pkgconfigmodel.Config) { | |||
| eventMonitorBindEnvAndSetDefault(cfg, join(evNS, "network.flow_monitor.period"), "10s") | |||
| eventMonitorBindEnvAndSetDefault(cfg, join(evNS, "network.raw_classifier_handle"), 0) | |||
| eventMonitorBindEnvAndSetDefault(cfg, join(evNS, "event_stream.use_ring_buffer"), true) | |||
| eventMonitorBindEnvAndSetDefault(cfg, join(evNS, "event_stream.use_fentry"), true) | |||
| eventMonitorBindEnvAndSetDefault(cfg, join(evNS, "event_stream.use_fentry"), false) | |||
There was a problem hiding this comment.
Would this break backward compatibility ?
There was a problem hiding this comment.
no, It won't. The old way to hook (kprobes) will be used as it is used on old kernel.
github-actions
bot
added
medium review
|
Do we have any more information on this bug, such as the kernel versions on which it happens, whether it is fixed upstream? |
Not yet, got some kernel version for which it is clearly broken and some it is not sure |
|
/merge |
Devflow running:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.62.x 7.62.x
# Navigate to the new working tree
cd .worktrees/backport-7.62.x
# Create a new branch
git switch --create backport-33692-to-7.62.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f9ce1e41dafc9f23cc4de3c3cfce2c50b4465990
# Push it to GitHub
git push --set-upstream origin backport-33692-to-7.62.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.62.xThen, create a pull request where the |
(cherry picked from commit f9ce1e4)
(cherry picked from commit f9ce1e4)
What does this PR do?
Disable fentry by default as it trigger a kernel bug.
Motivation
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes