Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve trace sampler metrics #33695

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Feb 4, 2025

What does this PR do?

  • Include RareSampler to datadog.trace_agent.sampler.{seen,kept}.
  • Include Probabilitic Sampler controled by DD_OTLP_CONFIG_TRACES_PROBABILISTIC_SAMPLER_SAMPLING_PERCENTAGE to datadog.trace_agent.sampler.{seen,kept}.
  • Condensed the logic for metrics related to the Sampler.

Motivation

Before this PR,

  • Rare Sampler was not included datadog.trace_agent.sampler.{seen,kept}.
  • datadog.trace_agent.sampler.{seen,kept} of Probabilitic Sampler controled by DD_OTLP_CONFIG_TRACES_PROBABILISTIC_SAMPLER_SAMPLING_PERCENTAGE was overwritten by Priority Sampler.
  • The logic for the Sampler’s metrics was scattered.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

This PR follows up on #33214

@github-actions github-actions bot added long review PR is complex, plan time to review it team/agent-apm trace-agent labels Feb 4, 2025
@keisku keisku added this to the 7.64.0 milestone Feb 4, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Uncompressed package size comparison

Comparison with ancestor 1237dc82016e7ffc6d738a5224ad9c0ea55b2916

Diff per package
package diff status size ancestor threshold
datadog-iot-agent-arm64-deb 0.00MB 82.50MB 82.50MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.57MB 82.57MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.17MB 59.17MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.17MB 59.17MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.56MB 56.56MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.23MB 86.23MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.00MB 86.30MB 86.30MB 0.50MB
datadog-iot-agent-x86_64-suse -0.00MB 86.30MB 86.30MB 0.50MB
datadog-agent-amd64-deb -0.00MB 873.44MB 873.45MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 883.18MB 883.19MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 883.18MB 883.19MB 0.50MB
datadog-heroku-agent-amd64-deb -0.00MB 445.69MB 445.70MB 0.50MB
datadog-agent-arm64-deb -0.01MB 861.33MB 861.34MB 0.50MB
datadog-agent-aarch64-rpm -0.01MB 871.05MB 871.06MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 844.71MiB 858.45MiB 203.56MiB 214.3MiB
static_quality_gate_docker_agent_amd64 929.14MiB 942.69MiB 310.69MiB 321.56MiB

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54953827 --os-family=ubuntu

Note: This applies to commit 63894e9

Copy link

cit-pr-commenter bot commented Feb 4, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 14648310-b94e-4ac9-bed9-818007baf0bd

Baseline: 1237dc8
Comparison: 63894e9
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +0.29 [+0.22, +0.36] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.19 [-0.60, +0.97] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.07 [-0.40, +0.54] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.85, +0.90] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.29, +0.26] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.72, +0.67] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.66, +0.61] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.86, +0.79] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.95, +0.86] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.10 [-0.16, -0.03] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.14 [-0.92, +0.64] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.25 [-1.11, +0.60] 1 Logs
quality_gate_idle_all_features memory utilization -0.32 [-0.38, -0.26] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.34 [-0.39, -0.28] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.49 [-3.52, +2.54] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@keisku keisku force-pushed the keisku/sampler-kept-seen-metrics branch from f8efdf2 to 95bc080 Compare February 4, 2025 23:40
@keisku keisku changed the title Include RareSampler to datadog.trace_agent.sampler.{seen,kept} Improve kept/seen metrics for all trace samplers Feb 4, 2025
@keisku keisku force-pushed the keisku/sampler-kept-seen-metrics branch 4 times, most recently from fb0be2c to 910a344 Compare February 5, 2025 08:30
@keisku keisku changed the title Improve kept/seen metrics for all trace samplers Improve trace sampler metrics Feb 5, 2025
@keisku keisku force-pushed the keisku/sampler-kept-seen-metrics branch 4 times, most recently from 5a446a2 to 63894e9 Compare February 5, 2025 10:56
@keisku keisku force-pushed the keisku/sampler-kept-seen-metrics branch from 63894e9 to fcf2ca4 Compare February 5, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long review PR is complex, plan time to review it team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant