Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build image in CircleCI #33712

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update build image in CircleCI #33712

merged 1 commit into from
Feb 4, 2025

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 4, 2025

Motivation

Finishing #33638

@ofek ofek added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra labels Feb 4, 2025
@ofek ofek requested a review from a team as a code owner February 4, 2025 18:28
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 4, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 56e1c70be579d8e239001375ef2ba983f6be370e

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.00MB 871.05MB 871.05MB 0.50MB
datadog-agent-amd64-deb 0.00MB 873.44MB 873.44MB 0.50MB
datadog-agent-arm64-deb 0.00MB 861.33MB 861.33MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.16MB 59.16MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.16MB 59.16MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.56MB 56.56MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 445.68MB 445.68MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.22MB 86.22MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.29MB 86.29MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.29MB 86.29MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.49MB 82.49MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.56MB 82.56MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 883.18MB 883.18MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 883.18MB 883.18MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 54880338 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2279a194-006d-48d6-b3f6-4dc975b5f10f

Baseline: 56e1c70
Comparison: 4ef2fa7
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.76 [-0.15, +1.66] 1 Logs
quality_gate_idle_all_features memory utilization +0.75 [+0.67, +0.83] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.11 [-0.77, +0.99] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.09 [-0.80, +0.98] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.05 [-0.73, +0.82] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.74, +0.75] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.28, +0.28] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.89, +0.88] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.62] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.23 [-0.70, +0.23] 1 Logs
quality_gate_idle memory utilization -0.26 [-0.29, -0.22] 1 Logs bounds checks dashboard
file_tree memory utilization -0.27 [-0.35, -0.20] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.34 [-1.12, +0.44] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.33 [-1.40, -1.25] 1 Logs
quality_gate_logs % cpu utilization -2.51 [-5.55, +0.53] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@chouetz
Copy link
Member

chouetz commented Feb 4, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 4, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-04 19:37:37 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 27m.


2025-02-04 20:06:47 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 77b2937 into main Feb 4, 2025
244 of 245 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ofek-patch-1 branch February 4, 2025 20:06
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants