Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTAGENT-285] Increase the scraping interval of collector internal metrics #33714

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Feb 4, 2025

What does this PR do?

Increase the scraping interval of internal metrics in embedded collector to 60s (from 10s)

Motivation

Current scraping interval of 10s leads to too much ingested data for collector internal metrics. This PR should reduce the volume of internal metrics to 1/6.

Describe how you validated your changes

covered in the existing tests

@songy23 songy23 added changelog/no-changelog team/opentelemetry OpenTelemetry team qa/done QA done before merge and regressions are covered by tests labels Feb 4, 2025
@songy23 songy23 added this to the 7.64.0 milestone Feb 4, 2025
@songy23 songy23 requested a review from mackjmr February 4, 2025 19:32
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Feb 4, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Uncompressed package size comparison

Comparison with ancestor 56e1c70be579d8e239001375ef2ba983f6be370e

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.00MB 871.05MB 871.05MB 0.50MB
datadog-agent-arm64-deb 0.00MB 861.33MB 861.33MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.16MB 59.16MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.16MB 59.16MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.56MB 56.56MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 445.68MB 445.68MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.22MB 86.22MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.29MB 86.29MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.29MB 86.29MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.49MB 82.49MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.56MB 82.56MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 883.18MB 883.18MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 883.18MB 883.18MB 0.50MB
datadog-agent-amd64-deb -0.00MB 873.44MB 873.44MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54929426 --os-family=ubuntu

Note: This applies to commit ee14549

Copy link

cit-pr-commenter bot commented Feb 4, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1b247c3d-252e-44da-8f11-4e1f371e1fe2

Baseline: 56e1c70
Comparison: ee14549
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.14 [+0.26, +2.01] 1 Logs
quality_gate_idle memory utilization +0.29 [+0.26, +0.32] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.23 [-0.55, +1.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.19 [-0.59, +0.97] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.18 [-0.58, +0.95] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.08 [-0.76, +0.92] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.08 [-0.80, +0.95] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.29] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.02, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.79, +0.75] 1 Logs
file_tree memory utilization -0.15 [-0.22, -0.07] 1 Logs
quality_gate_idle_all_features memory utilization -0.17 [-0.24, -0.10] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.17 [-0.65, +0.30] 1 Logs
quality_gate_logs % cpu utilization -0.38 [-3.40, +2.64] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.43 [-0.53, -0.34] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@songy23 songy23 marked this pull request as ready for review February 4, 2025 20:32
@songy23 songy23 requested review from a team as code owners February 4, 2025 20:32
@songy23 songy23 requested a review from dustmop February 4, 2025 20:32
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for agent-configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants