Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTAGENT-268] upgrade otel package versions to v0.119.0 #33715

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Feb 4, 2025

What does this PR do?

Upgrade otel package versions to v0.119.0 with inv collector.update

Motivation

Keep otel dependencies up to date

Describe how you validated your changes

covered with the current tests

@songy23 songy23 added changelog/no-changelog team/opentelemetry OpenTelemetry team qa/done QA done before merge and regressions are covered by tests labels Feb 4, 2025
@songy23 songy23 added this to the 7.64.0 milestone Feb 4, 2025
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Feb 4, 2025
Copy link

cit-pr-commenter bot commented Feb 4, 2025

Go Package Import Differences

Baseline: edca09e
Comparison: 6fa57ee

binaryosarchchange
agentlinuxamd64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform
agentlinuxarm64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform
agentwindowsamd64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform
agentdarwinamd64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform
agentdarwinarm64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform
iot-agentlinuxamd64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform
iot-agentlinuxarm64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform
heroku-agentlinuxamd64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform
serverlesslinuxamd64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform
serverlesslinuxarm64
+6, -3
-go.opentelemetry.io/collector/exporter/internal/requesttest
-go.opentelemetry.io/collector/service/telemetry/internal/otelinit
+go.opentelemetry.io/collector/service/telemetry/internal/migration
-go.opentelemetry.io/contrib/config
+go.opentelemetry.io/contrib/config/v0.2.0
+go.opentelemetry.io/contrib/config/v0.3.0
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/retry
+go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc/internal/transform

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54998457 --os-family=ubuntu

Note: This applies to commit 6fa57ee

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 4, 2025

Uncompressed package size comparison

Comparison with ancestor edca09e7eddcb602d378bb77ced1de9bf4a69b03

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 0.35MB ⚠️ 446.05MB 445.70MB 0.50MB
datadog-iot-agent-amd64-deb 0.24MB ⚠️ 86.47MB 86.23MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.24MB ⚠️ 86.54MB 86.30MB 0.50MB
datadog-iot-agent-x86_64-suse 0.24MB ⚠️ 86.54MB 86.30MB 0.50MB
datadog-iot-agent-arm64-deb 0.24MB ⚠️ 82.74MB 82.50MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.24MB ⚠️ 82.81MB 82.57MB 0.50MB
datadog-agent-aarch64-rpm 0.20MB ⚠️ 871.27MB 871.06MB 0.50MB
datadog-agent-x86_64-rpm 0.20MB ⚠️ 883.40MB 883.19MB 0.50MB
datadog-agent-x86_64-suse 0.20MB ⚠️ 883.40MB 883.19MB 0.50MB
datadog-agent-amd64-deb 0.20MB ⚠️ 873.66MB 873.45MB 0.50MB
datadog-agent-arm64-deb 0.20MB ⚠️ 861.54MB 861.34MB 0.50MB
datadog-dogstatsd-arm64-deb 0.02MB ⚠️ 56.58MB 56.56MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.01MB ⚠️ 59.18MB 59.16MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.01MB ⚠️ 59.18MB 59.16MB 0.50MB
datadog-dogstatsd-amd64-deb 0.01MB ⚠️ 59.10MB 59.09MB 0.50MB

Decision

⚠️ Warning

@songy23 songy23 marked this pull request as ready for review February 4, 2025 21:59
@songy23 songy23 requested review from a team as code owners February 4, 2025 21:59
@songy23 songy23 requested review from IbraheemA and truthbk February 4, 2025 21:59
@dineshg13 dineshg13 removed the request for review from IbraheemA February 4, 2025 22:09
Copy link

cit-pr-commenter bot commented Feb 4, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e3a38fa2-4095-4374-8ab1-ef050dea38c1

Baseline: edca09e
Comparison: 6fa57ee
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +0.86 [+0.77, +0.94] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.24 [-0.23, +0.71] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.07 [-0.82, +0.95] 1 Logs
quality_gate_idle memory utilization +0.05 [+0.01, +0.09] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.65] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.29, +0.31] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.60, +0.62] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.03] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.92, +0.87] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.89, +0.80] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.85, +0.71] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.08 [-0.87, +0.71] 1 Logs
file_tree memory utilization -0.19 [-0.25, -0.12] 1 Logs
quality_gate_logs % cpu utilization -0.71 [-3.74, +2.33] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.69 [-2.58, -0.79] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.91 [-1.98, -1.84] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 844.92MiB 858.45MiB 203.55MiB 214.3MiB
static_quality_gate_docker_agent_amd64 929.34MiB 942.69MiB 310.75MiB 321.56MiB

@songy23
Copy link
Member Author

songy23 commented Feb 5, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 5, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-05 18:15:43 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.


2025-02-05 18:49:53 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 82f052c into main Feb 5, 2025
426 of 427 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yang.song/OTAGENT-268 branch February 5, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants