chore: asm serverless upgrade #33790

genesor · 2025-02-06T15:40:39Z

What does this PR do?

This PR updates the appsec-internal-go to v1.10.0 with an updated ruleset

It also adds some appsec related tags that were missing in the serverless agent.

Describe how you validated your changes

New integration tests validating the presence of appsec related tags in the normalized logs, their value does not really matter so checking their non emptiness is enough.

The format of the appsec snapshot have changed to fit this new need. In the previous format each entry was the content of the _dd.appsec.json meta tag. Now the snapshot entries are made of appsec.json and tags.

{
    "appsec.json": { 
		%content of the _dd.appsec.json tag%
	},
    "tags": {
      "_dd.appsec.event_rules.error_count": "NOT_FOUND",
      "_dd.appsec.event_rules.errors": "NOT_FOUND",
      "_dd.appsec.event_rules.loaded": "NOT_FOUND",
      "_dd.appsec.event_rules.version": "FOUND",
      "_dd.appsec.waf.duration_ext": "FOUND",
      "_dd.appsec.waf.version": "NOT_FOUND",
      "_dd.origin": "FOUND",
      "appsec.event": "FOUND"
    }
}

bits-bot · 2025-02-06T15:40:44Z

All committers have signed the CLA.

agent-platform-auto-pr · 2025-02-06T16:30:56Z

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	837.77MiB	847.49MiB	202.76MiB	212.83MiB
✅	static_quality_gate_agent_deb_arm64	826.74MiB	836.66MiB	182.22MiB	192.17MiB
✅	static_quality_gate_agent_rpm_amd64	837.59MiB	858.45MiB	206.19MiB	214.3MiB
✅	static_quality_gate_agent_rpm_arm64	826.6MiB	836.66MiB	184.45MiB	194.46MiB
✅	static_quality_gate_agent_suse_amd64	837.66MiB	858.45MiB	206.19MiB	214.3MiB
✅	static_quality_gate_agent_suse_arm64	826.59MiB	836.66MiB	184.45MiB	194.46MiB
✅	static_quality_gate_dogstatsd_deb_amd64	39.5MiB	49.7MiB	10.54MiB	20.6MiB
✅	static_quality_gate_dogstatsd_deb_arm64	37.85MiB	48.1MiB	9.11MiB	19.1MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	39.5MiB	49.7MiB	10.55MiB	20.6MiB
✅	static_quality_gate_dogstatsd_suse_amd64	39.5MiB	49.7MiB	10.55MiB	20.6MiB
✅	static_quality_gate_iot_agent_deb_amd64	58.97MiB	69.0MiB	14.82MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.35MiB	66.4MiB	12.79MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	58.97MiB	69.0MiB	14.83MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.35MiB	66.4MiB	12.8MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	58.97MiB	69.0MiB	14.83MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	922.02MiB	931.7MiB	308.78MiB	318.67MiB
✅	static_quality_gate_docker_agent_arm64	934.37MiB	944.08MiB	292.74MiB	303.0MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.09GiB	1.1GiB	383.87MiB	393.75MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.09GiB	1.1GiB	363.83MiB	373.71MiB
✅	static_quality_gate_docker_dogstatsd_amd64	47.64MiB	57.88MiB	18.24MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	46.04MiB	56.27MiB	17.0MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	267.76MiB	277.7MiB	107.27MiB	117.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	283.81MiB	293.73MiB	102.14MiB	112.12MiB

agent-platform-auto-pr · 2025-02-06T16:30:57Z

Uncompressed package size comparison

Comparison with ancestor 94217a6ff0ed0c51a08d7c2bb44c3cdc10ced66b

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	865.98MB	865.97MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	875.74MB	875.74MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	875.74MB	875.74MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	441.05MB	441.05MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	854.47MB	854.47MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	864.22MB	864.22MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	41.34MB	41.34MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	41.42MB	41.42MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	41.42MB	41.42MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	39.61MB	39.61MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	61.76MB	61.76MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	61.83MB	61.83MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	61.83MB	61.83MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.01MB	59.01MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.08MB	59.08MB	0.50MB

Decision

✅ Passed

cit-pr-commenter · 2025-02-06T16:56:55Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ca9160b3-1820-4e97-86a6-68fbc5aa77e2

Baseline: 94217a6
Comparison: be2f94c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+3.97	[+0.82, +7.12]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.48	[-0.41, +1.37]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.31	[-0.47, +1.09]	1	Logs
➖	file_tree	memory utilization	+0.26	[+0.20, +0.32]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.13	[-0.35, +0.60]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.09	[-0.82, +0.99]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.03	[-0.03, +0.09]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.92, +0.94]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.01	[-0.89, +0.90]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.64, +0.64]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.02, +0.02]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.31, +0.29]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.03	[-0.73, +0.67]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.82, +0.74]	1	Logs
➖	quality_gate_idle	memory utilization	-0.08	[-0.14, -0.02]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.78	[-0.83, -0.72]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

pkg/serverless/appsec/appsec_test.go

pkg/serverless/appsec/httpsec/http.go

pkg/serverless/appsec/httpsec/proxy.go

pkg/serverless/appsec/httpsec/tags.go

test/integration/serverless/src/go-tests/appsec/main.go

test/integration/serverless/src/go.mod

agent-platform-auto-pr · 2025-02-07T16:47:57Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55899727 --os-family=ubuntu

Note: This applies to commit be2f94c

go.work

dustmop

LGTM for agent-configuration changes.

…sm-serverless-upgrade

genesor · 2025-02-12T16:29:59Z

Currently waiting on #33988 to be merged to fix the Serverless Integration Tests

genesor · 2025-02-13T15:45:29Z

/merge

dd-devflow · 2025-02-13T15:45:34Z

View all feedbacks in Devflow UI.
2025-02-13 15:45:34 UTC ℹ️ Start processing command /merge

2025-02-13 15:45:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-13 15:53:50 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

genesor · 2025-02-13T15:53:34Z

/remove

dd-devflow · 2025-02-13T15:53:38Z

View all feedbacks in Devflow UI.
2025-02-13 15:53:38 UTC ℹ️ Start processing command /remove

2025-02-13 15:53:54 UTC ℹ️ Devflow: /remove

genesor · 2025-02-13T15:54:23Z

/merge

dd-devflow · 2025-02-13T15:54:28Z

View all feedbacks in Devflow UI.
2025-02-13 15:54:28 UTC ℹ️ Start processing command /merge

2025-02-13 15:54:35 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-13 19:55:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

…sm-serverless-upgrade

github-actions · 2025-02-14T08:19:00Z

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 94217a6 and 8841acf.

tl;dr

Use these benchmarks as an insight tool during development.

Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.
The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │         sec/op         │    sec/op     vs base               │
api-gateway-appsec.json                            84.93µ ± 3%    88.33µ ± 1%  +4.00% (p=0.002 n=10)
api-gateway-kong-appsec.json                       65.99µ ± 1%    69.90µ ± 4%  +5.92% (p=0.000 n=10)
api-gateway-kong.json                              62.53µ ± 0%    66.79µ ± 2%  +6.80% (p=0.000 n=10)
api-gateway-non-proxy-async.json                   99.25µ ± 2%   103.82µ ± 2%  +4.60% (p=0.000 n=10)
api-gateway-non-proxy.json                         97.88µ ± 3%   105.68µ ± 2%  +7.97% (p=0.000 n=10)
api-gateway-websocket-connect.json                 63.66µ ± 1%    67.10µ ± 2%  +5.40% (p=0.000 n=10)
api-gateway-websocket-default.json                 57.16µ ± 3%    60.28µ ± 3%  +5.44% (p=0.000 n=10)
api-gateway-websocket-disconnect.json              58.08µ ± 2%    63.31µ ± 2%  +9.01% (p=0.000 n=10)
api-gateway.json                                   107.2µ ± 1%    117.4µ ± 2%  +9.54% (p=0.000 n=10)
application-load-balancer.json                     58.14µ ± 1%    60.49µ ± 3%  +4.04% (p=0.000 n=10)
cloudfront.json                                    44.21µ ± 1%    46.01µ ± 2%  +4.06% (p=0.000 n=10)
cloudwatch-events.json                             36.86µ ± 1%    37.79µ ± 1%  +2.51% (p=0.000 n=10)
cloudwatch-logs.json                               61.96µ ± 2%    61.99µ ± 1%       ~ (p=0.739 n=10)
custom.json                                        31.20µ ± 1%    32.09µ ± 3%  +2.83% (p=0.001 n=10)
dynamodb.json                                      84.74µ ± 1%    86.74µ ± 4%  +2.37% (p=0.000 n=10)
empty.json                                         29.00µ ± 0%    30.35µ ± 3%  +4.63% (p=0.000 n=10)
eventbridge-custom.json                            44.52µ ± 1%    46.87µ ± 1%  +5.27% (p=0.000 n=10)
eventbridge-no-bus.json                            43.89µ ± 1%    45.34µ ± 2%  +3.32% (p=0.000 n=10)
eventbridge-no-timestamp.json                      43.76µ ± 1%    45.06µ ± 4%  +2.98% (p=0.000 n=10)
eventbridgesns.json                                58.17µ ± 1%    59.29µ ± 1%  +1.92% (p=0.000 n=10)
eventbridgesqs.json                                64.92µ ± 1%    66.34µ ± 2%  +2.20% (p=0.001 n=10)
http-api.json                                      63.50µ ± 3%    65.18µ ± 1%  +2.66% (p=0.007 n=10)
kinesis-batch.json                                 64.58µ ± 1%    65.81µ ± 3%  +1.91% (p=0.000 n=10)
kinesis.json                                       51.54µ ± 1%    53.27µ ± 1%  +3.35% (p=0.000 n=10)
s3.json                                            55.17µ ± 2%    57.00µ ± 2%  +3.33% (p=0.003 n=10)
sns-batch.json                                     82.99µ ± 1%    86.19µ ± 0%  +3.85% (p=0.000 n=10)
sns.json                                           61.95µ ± 1%    64.01µ ± 1%  +3.33% (p=0.000 n=10)
snssqs.json                                        105.7µ ± 1%    109.4µ ± 2%  +3.47% (p=0.000 n=10)
snssqs_no_dd_context.json                          95.94µ ± 1%   100.17µ ± 3%  +4.41% (p=0.000 n=10)
sqs-aws-header.json                                52.50µ ± 1%    54.50µ ± 1%  +3.80% (p=0.000 n=10)
sqs-batch.json                                     85.93µ ± 2%    90.24µ ± 3%  +5.02% (p=0.000 n=10)
sqs.json                                           63.14µ ± 1%    66.58µ ± 2%  +5.45% (p=0.000 n=10)
sqs_no_dd_context.json                             57.50µ ± 0%    60.90µ ± 1%  +5.91% (p=0.000 n=10)
stepfunction.json                                  40.61µ ± 1%    43.02µ ± 3%  +5.95% (p=0.000 n=10)
geomean                                            60.82µ         63.44µ       +4.31%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.40Ki ± 0%   37.40Ki ± 0%       ~ (p=0.359 n=10)
api-gateway-kong-appsec.json                      27.13Ki ± 0%   27.13Ki ± 0%       ~ (p=0.982 n=10)
api-gateway-kong.json                             24.62Ki ± 0%   24.62Ki ± 0%       ~ (p=0.400 n=10)
api-gateway-non-proxy-async.json                  47.99Ki ± 0%   47.99Ki ± 0%       ~ (p=0.493 n=10)
api-gateway-non-proxy.json                        47.19Ki ± 0%   47.19Ki ± 0%       ~ (p=0.469 n=10)
api-gateway-websocket-connect.json                25.37Ki ± 0%   25.37Ki ± 0%       ~ (p=0.064 n=10)
api-gateway-websocket-default.json                20.09Ki ± 0%   20.09Ki ± 0%       ~ (p=0.989 n=10)
api-gateway-websocket-disconnect.json             21.00Ki ± 0%   21.00Ki ± 0%  -0.02% (p=0.003 n=10)
api-gateway.json                                  49.18Ki ± 0%   49.17Ki ± 0%       ~ (p=0.060 n=10)
application-load-balancer.json                    23.40Ki ± 0%   23.40Ki ± 0%  -0.01% (p=0.038 n=10)
cloudfront.json                                   17.48Ki ± 0%   17.48Ki ± 0%       ~ (p=0.342 n=10)
cloudwatch-events.json                            11.55Ki ± 0%   11.55Ki ± 0%       ~ (p=0.969 n=10)
cloudwatch-logs.json                              53.07Ki ± 0%   53.07Ki ± 0%       ~ (p=0.925 n=10)
custom.json                                       9.572Ki ± 0%   9.572Ki ± 0%       ~ (p=0.154 n=10)
dynamodb.json                                     40.37Ki ± 0%   40.37Ki ± 0%       ~ (p=0.462 n=10)
empty.json                                        9.109Ki ± 0%   9.109Ki ± 0%       ~ (p=0.150 n=10)
eventbridge-custom.json                           14.73Ki ± 0%   14.73Ki ± 0%       ~ (p=0.072 n=10)
eventbridge-no-bus.json                           13.70Ki ± 0%   13.70Ki ± 0%       ~ (p=0.596 n=10)
eventbridge-no-timestamp.json                     13.70Ki ± 0%   13.70Ki ± 0%       ~ (p=0.311 n=10)
eventbridgesns.json                               20.50Ki ± 0%   20.50Ki ± 0%       ~ (p=0.392 n=10)
eventbridgesqs.json                               24.63Ki ± 0%   24.63Ki ± 0%       ~ (p=0.399 n=10)
http-api.json                                     23.46Ki ± 0%   23.46Ki ± 0%       ~ (p=0.777 n=10)
kinesis-batch.json                                26.57Ki ± 0%   26.57Ki ± 0%       ~ (p=0.637 n=10)
kinesis.json                                      17.45Ki ± 0%   17.45Ki ± 0%       ~ (p=0.442 n=10)
s3.json                                           19.96Ki ± 0%   19.96Ki ± 0%       ~ (p=0.064 n=10)
sns-batch.json                                    39.13Ki ± 0%   39.13Ki ± 0%  -0.01% (p=0.035 n=10)
sns.json                                          24.57Ki ± 0%   24.56Ki ± 0%       ~ (p=0.823 n=10)
snssqs.json                                       52.81Ki ± 0%   52.80Ki ± 0%  -0.01% (p=0.045 n=10)
snssqs_no_dd_context.json                         46.56Ki ± 0%   46.56Ki ± 0%       ~ (p=0.146 n=10)
sqs-aws-header.json                               18.80Ki ± 0%   18.80Ki ± 0%       ~ (p=0.896 n=10)
sqs-batch.json                                    41.34Ki ± 0%   41.34Ki ± 0%       ~ (p=0.122 n=10)
sqs.json                                          25.44Ki ± 0%   25.44Ki ± 0%  -0.01% (p=0.011 n=10)
sqs_no_dd_context.json                            21.09Ki ± 0%   21.09Ki ± 0%  -0.01% (p=0.049 n=10)
stepfunction.json                                 13.53Ki ± 0%   13.53Ki ± 0%       ~ (p=0.162 n=10)
geomean                                           24.16Ki        24.16Ki       -0.00%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             637.0 ± 0%   637.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong-appsec.json                        495.0 ± 0%   495.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               473.0 ± 0%   473.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    738.0 ± 0%   738.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy.json                          728.0 ± 0%   728.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-connect.json                  455.0 ± 0%   455.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-default.json                  376.0 ± 0%   376.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-disconnect.json               368.0 ± 0%   368.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway.json                                    799.0 ± 0%   799.0 ± 0%       ~ (p=1.000 n=10) ¹
application-load-balancer.json                      353.0 ± 0%   353.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudfront.json                                     278.0 ± 0%   278.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-events.json                              215.0 ± 0%   215.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-logs.json                                208.0 ± 0%   208.0 ± 0%       ~ (p=1.000 n=10) ¹
custom.json                                         163.0 ± 0%   163.0 ± 0%       ~ (p=1.000 n=10) ¹
dynamodb.json                                       581.0 ± 0%   581.0 ± 0%       ~ (p=1.000 n=10) ¹
empty.json                                          154.0 ± 0%   154.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-custom.json                             260.0 ± 0%   260.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-no-bus.json                             251.0 ± 0%   251.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-no-timestamp.json                       251.0 ± 0%   251.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridgesns.json                                 315.0 ± 0%   315.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridgesqs.json                                 355.0 ± 0%   355.0 ± 0%       ~ (p=1.000 n=10) ¹
http-api.json                                       431.0 ± 0%   431.0 ± 0%       ~ (p=1.000 n=10) ¹
kinesis-batch.json                                  382.0 ± 0%   382.0 ± 0%       ~ (p=1.000 n=10) ¹
kinesis.json                                        278.0 ± 0%   278.0 ± 0%       ~ (p=1.000 n=10) ¹
s3.json                                             350.0 ± 0%   350.0 ± 0%       ~ (p=1.000 n=10) ¹
sns-batch.json                                      466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
sns.json                                            337.0 ± 0%   337.0 ± 0%       ~ (p=1.000 n=10) ¹
snssqs.json                                         459.0 ± 0%   459.0 ± 0%       ~ (p=1.000 n=10) ¹
snssqs_no_dd_context.json                           419.0 ± 0%   419.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs-aws-header.json                                 275.0 ± 0%   275.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs-batch.json                                      501.0 ± 0%   501.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs.json                                            350.0 ± 0%   350.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs_no_dd_context.json                              336.0 ± 0%   336.0 ± 0%       ~ (p=1.000 n=10) ¹
stepfunction.json                                   223.0 ± 0%   223.0 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                             360.1        360.1       +0.00%
¹ all samples are equal

genesor · 2025-02-14T08:29:52Z

/merge

dd-devflow · 2025-02-14T08:29:55Z

View all feedbacks in Devflow UI.
2025-02-14 08:29:55 UTC ℹ️ Start processing command /merge

2025-02-14 08:29:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-14 09:14:11 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 33m.

2025-02-14 10:04:28 UTC ℹ️ MergeQueue: This merge request was merged

genesor force-pushed the ben.db/APPSEC-56208-asm-serverless-upgrade branch from d644586 to 07013f4 Compare February 6, 2025 15:49

github-actions bot added the long review PR is complex, plan time to review it label Feb 6, 2025

genesor force-pushed the ben.db/APPSEC-56208-asm-serverless-upgrade branch from 07013f4 to 05e7170 Compare February 6, 2025 16:02

genesor and others added 7 commits February 7, 2025 15:15

chore: remove go-libddwaf deprecated calls

45c2583

chore: update appsec-internal-go to v1.10.0

61dec12

add new tags to ASM serverless traces

46ca055

remove deprecated calls from serverless go integration tests

25c8c96

Add missing attrs in serverless integration tests.

5d27322

remove redundant tags

d52b8d6

add new data to appsec normalized logs

c3f7aa4

genesor force-pushed the ben.db/APPSEC-56208-asm-serverless-upgrade branch from 2212802 to c3f7aa4 Compare February 7, 2025 14:17

genesor marked this pull request as ready for review February 7, 2025 14:31

genesor requested review from a team as code owners February 7, 2025 14:31

genesor requested a review from jose-manuel-almaza February 7, 2025 14:31

genesor added changelog/no-changelog team/agent-appsec labels Feb 7, 2025

RomainMuller requested changes Feb 7, 2025

View reviewed changes

cs improvements

64b4484

genesor requested a review from RomainMuller February 7, 2025 16:18

add missing new snapshot for appsec csharp

a384ef5

jose-manuel-almaza approved these changes Feb 10, 2025

View reviewed changes

Update go-libddwaf to v3.5.2

264153d

KevinFairise2 reviewed Feb 11, 2025

View reviewed changes

go.work Outdated Show resolved Hide resolved

dustmop approved these changes Feb 11, 2025

View reviewed changes

genesor added 3 commits February 12, 2025 09:43

Fix integration serverless go module name

d7a8d3e

Merge remote-tracking branch 'origin/main' into ben.db/APPSEC-56208-a…

28ec5c5

…sm-serverless-upgrade

Remove integration test serverless package from go.work

52d631f

genesor force-pushed the ben.db/APPSEC-56208-asm-serverless-upgrade branch 2 times, most recently from 88f957e to 52d631f Compare February 12, 2025 14:10

genesor requested a review from KevinFairise2 February 12, 2025 16:31

Merge branch 'main' into ben.db/APPSEC-56208-asm-serverless-upgrade

60b3673

songy23 approved these changes Feb 13, 2025

View reviewed changes

liustanley approved these changes Feb 13, 2025

View reviewed changes

duncanista approved these changes Feb 13, 2025

View reviewed changes

genesor removed request for ankitpatel96 and KevinFairise2 February 13, 2025 15:49

Merge remote-tracking branch 'origin/main' into ben.db/APPSEC-56208-a…

be2f94c

…sm-serverless-upgrade

genesor requested a review from KevinFairise2 February 14, 2025 08:28

KevinFairise2 approved these changes Feb 14, 2025

View reviewed changes

dd-mergequeue bot merged commit 4f44d13 into main Feb 14, 2025
439 of 442 checks passed

dd-mergequeue bot deleted the ben.db/APPSEC-56208-asm-serverless-upgrade branch February 14, 2025 10:04

github-actions bot added this to the 7.64.0 milestone Feb 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: asm serverless upgrade #33790

chore: asm serverless upgrade #33790

genesor commented Feb 6, 2025 •

edited

Loading

bits-bot commented Feb 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

Info

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 6, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

agent-platform-auto-pr bot commented Feb 7, 2025 •

edited

Loading

dustmop left a comment

genesor commented Feb 12, 2025 •

edited

Loading

genesor commented Feb 13, 2025

dd-devflow bot commented Feb 13, 2025 •

edited

Loading

genesor commented Feb 13, 2025

dd-devflow bot commented Feb 13, 2025 •

edited

Loading

genesor commented Feb 13, 2025

dd-devflow bot commented Feb 13, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025

genesor commented Feb 14, 2025

dd-devflow bot commented Feb 14, 2025 •

edited

Loading

chore: asm serverless upgrade #33790

chore: asm serverless upgrade #33790

Conversation

genesor commented Feb 6, 2025 • edited Loading

What does this PR do?

Describe how you validated your changes

bits-bot commented Feb 6, 2025 • edited Loading

agent-platform-auto-pr bot commented Feb 6, 2025 • edited Loading

Static quality checks ✅

Info

agent-platform-auto-pr bot commented Feb 6, 2025 • edited Loading

Uncompressed package size comparison

Decision

cit-pr-commenter bot commented Feb 6, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Feb 7, 2025 • edited Loading

Test changes on VM

dustmop left a comment

Choose a reason for hiding this comment

genesor commented Feb 12, 2025 • edited Loading

genesor commented Feb 13, 2025

dd-devflow bot commented Feb 13, 2025 • edited Loading

genesor commented Feb 13, 2025

dd-devflow bot commented Feb 13, 2025 • edited Loading

genesor commented Feb 13, 2025

dd-devflow bot commented Feb 13, 2025 • edited Loading

github-actions bot commented Feb 14, 2025

Serverless Benchmark Results

genesor commented Feb 14, 2025

dd-devflow bot commented Feb 14, 2025 • edited Loading

genesor commented Feb 6, 2025 •

edited

Loading

bits-bot commented Feb 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 6, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 6, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 7, 2025 •

edited

Loading

genesor commented Feb 12, 2025 •

edited

Loading

dd-devflow bot commented Feb 13, 2025 •

edited

Loading

dd-devflow bot commented Feb 13, 2025 •

edited

Loading

dd-devflow bot commented Feb 13, 2025 •

edited

Loading

dd-devflow bot commented Feb 14, 2025 •

edited

Loading