Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang from 1.23.5-alpine3.20 to 1.23.6-alpine3.20 in /test/fakeintake #33895

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 10, 2025

Bumps golang from 1.23.5-alpine3.20 to 1.23.6-alpine3.20.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps golang from 1.23.5-alpine3.20 to 1.23.6-alpine3.20.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested review from a team as code owners February 10, 2025 20:55
@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dev/testing qa/no-code-change No code change in Agent code requiring validation team/agent-e2e-test labels Feb 10, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 8b7083d5e900d289a5bab724ab66b3a45677754b

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 869.11MB 869.11MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 878.88MB 878.88MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 878.88MB 878.88MB 0.50MB
datadog-agent-arm64-deb 0.00MB 857.53MB 857.53MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 867.28MB 867.28MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.04MB 59.04MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.53MB 56.53MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 441.07MB 441.07MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.35MB 86.35MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.63MB 82.63MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.70MB 82.70MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 840.6MiB 858.45MiB 203.56MiB 214.3MiB
static_quality_gate_docker_agent_amd64 925.01MiB 942.69MiB 309.88MiB 321.56MiB
static_quality_gate_docker_agent_arm64 937.29MiB 952.69MiB 293.76MiB 351.22MiB
static_quality_gate_docker_agent_jmx_amd64 1.1GiB 1.11GiB 384.98MiB 395.8MiB
static_quality_gate_docker_agent_jmx_arm64 1.1GiB 1.11GiB 364.85MiB 375.5MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.26MiB 56.27MiB 17.05MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.69MiB 277.7MiB 107.27MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.73MiB 293.73MiB 102.1MiB 112.12MiB

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 55461499 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b168c9c0-0563-4141-89a3-71b264b16a2f

Baseline: 8b7083d
Comparison: 3d1dcbd
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +15.20 [+11.73, +18.66] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +15.20 [+11.73, +18.66] 1 Logs
quality_gate_idle_all_features memory utilization +0.09 [+0.03, +0.15] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.07 [+0.01, +0.12] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.90, +0.98] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.02 [-0.03, +0.07] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.29] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.04, +0.03] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.65, +0.64] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.65, +0.62] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.82, +0.77] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.91, +0.84] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.09 [-0.90, +0.72] 1 Logs
file_tree memory utilization -0.13 [-0.19, -0.07] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.16 [-0.93, +0.61] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.25 [-0.71, +0.22] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.91 [-1.83, +0.02] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@chouetz
Copy link
Member

chouetz commented Feb 12, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 12, 2025

View all feedbacks in Devflow UI.
2025-02-12 09:39:39 UTC ℹ️ Start processing command /merge


2025-02-12 09:39:42 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.


2025-02-12 10:11:52 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 894e9ba into main Feb 12, 2025
267 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dependabot/docker/test/fakeintake/golang-1.23.6-alpine3.20 branch February 12, 2025 10:11
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dev/testing qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-e2e-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant