Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing gitignore for service discovery #33898

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

brycekahle
Copy link
Member

@brycekahle brycekahle commented Feb 10, 2025

What does this PR do?

Adds the generated runtime .go file to .gitignore.

Motivation

These generated files should not be checked in.

Describe how you validated your changes

n/a

Possible Drawbacks / Trade-offs

Additional Notes

added in #33602

@brycekahle brycekahle added changelog/no-changelog team/usm The USM team qa/no-code-change No code change in Agent code requiring validation labels Feb 10, 2025
@brycekahle brycekahle added this to the 7.64.0 milestone Feb 10, 2025
@brycekahle brycekahle requested a review from a team as a code owner February 10, 2025 21:31
@brycekahle brycekahle added the ask-review Ask required teams to review this PR label Feb 10, 2025
@github-actions github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly labels Feb 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 55466499 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 8b7083d5e900d289a5bab724ab66b3a45677754b

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 869.11MB 869.11MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 878.88MB 878.88MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 878.88MB 878.88MB 0.50MB
datadog-agent-arm64-deb 0.00MB 857.53MB 857.53MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 867.28MB 867.28MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.04MB 59.04MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.53MB 56.53MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 441.07MB 441.07MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.35MB 86.35MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.63MB 82.63MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.70MB 82.70MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 840.72MiB 858.45MiB 203.56MiB 214.3MiB
static_quality_gate_docker_agent_amd64 925.01MiB 942.69MiB 309.88MiB 321.56MiB
static_quality_gate_docker_agent_arm64 937.29MiB 952.69MiB 293.77MiB 351.22MiB
static_quality_gate_docker_agent_jmx_amd64 1.1GiB 1.11GiB 384.97MiB 395.8MiB
static_quality_gate_docker_agent_jmx_arm64 1.1GiB 1.11GiB 364.85MiB 375.5MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.26MiB 56.27MiB 17.05MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.69MiB 277.7MiB 107.27MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.73MiB 293.73MiB 102.1MiB 112.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c81acca5-e847-4f55-869c-e19f34546d0a

Baseline: 8b7083d
Comparison: 61a1b0b
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.54 [+0.67, +2.41] 1 Logs
quality_gate_logs % cpu utilization +1.32 [-1.75, +4.39] 1 Logs
file_tree memory utilization +0.59 [+0.53, +0.65] 1 Logs
quality_gate_idle_all_features memory utilization +0.35 [+0.28, +0.42] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.16 [+0.13, +0.20] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.13 [-0.65, +0.91] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.09 [-0.69, +0.86] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.62, +0.61] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.28, +0.25] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.85, +0.80] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.96, +0.87] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.87, +0.78] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.29 [-0.75, +0.18] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.57 [-1.64, -1.49] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@guyarb guyarb added team/agent-discovery and removed team/usm The USM team labels Feb 11, 2025
@paulcacheux
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 11, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-11 09:45:40 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 31m.


2025-02-11 10:11:47 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit cc4105e into main Feb 11, 2025
377 checks passed
@dd-mergequeue dd-mergequeue bot deleted the bryce.kahle/sd-runtime-ignore branch February 11, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-review Ask required teams to review this PR changelog/no-changelog component/system-probe qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-discovery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants