Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBPF] gpu: parse kernels only for architectures present in the host #33903

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

gjulianm
Copy link
Contributor

@gjulianm gjulianm commented Feb 10, 2025

What does this PR do?

This PR changes the Fatbin parsing code to ensure that we only read kernels for the architectures we care about, which are those of the devices present in the host.

Motivation

Reduce memory usage of the fatbin parsing code. Also validated in venomoth that there's a memory usage reduction.

Describe how you validated your changes

Unit tests ensure that the behavior is correct.

Possible Drawbacks / Trade-offs

Additional Notes

@gjulianm gjulianm self-assigned this Feb 10, 2025
@github-actions github-actions bot added medium review PR review might take time team/ebpf-platform labels Feb 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 837.26MiB 858.45MiB 202.9MiB 214.3MiB
static_quality_gate_docker_agent_amd64 921.66MiB 942.69MiB 308.66MiB 321.56MiB
static_quality_gate_docker_agent_arm64 934.04MiB 952.69MiB 292.63MiB 351.22MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.72MiB 395.8MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.71MiB 375.5MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.26MiB 56.27MiB 17.06MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.69MiB 277.7MiB 107.27MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.74MiB 293.73MiB 102.11MiB 112.12MiB

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

Uncompressed package size comparison

Comparison with ancestor 25c08a68d14a2abb29b791c1fc9a494e61b5631e

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.00MB 863.87MB 863.87MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 875.37MB 875.37MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 875.37MB 875.37MB 0.50MB
datadog-agent-amd64-deb 0.00MB 865.60MB 865.60MB 0.50MB
datadog-agent-arm64-deb 0.00MB 854.12MB 854.12MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.04MB 59.04MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.53MB 56.53MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.97MB 440.97MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.36MB 86.36MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.43MB 86.43MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.62MB 82.62MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.69MB 82.69MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55554700 --os-family=ubuntu

Note: This applies to commit d433554

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

[Fast Unit Tests Report]

On pipeline 55554700 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Feb 11, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7f989fa3-a0f1-4ea3-b528-9b98984e1c42

Baseline: 25c08a6
Comparison: d433554
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +1.28 [+0.48, +2.07] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.42 [-0.51, +1.34] 1 Logs
quality_gate_idle memory utilization +0.07 [+0.04, +0.10] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.07 [-0.81, +0.94] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.74, +0.82] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.67, +0.72] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.26, +0.28] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.90, +0.92] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.63, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.88, +0.84] 1 Logs
quality_gate_idle_all_features memory utilization -0.09 [-0.16, -0.01] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.23 [-0.69, +0.24] 1 Logs
file_tree memory utilization -0.24 [-0.31, -0.18] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.88 [-0.95, -0.81] 1 Logs
quality_gate_logs % cpu utilization -3.78 [-6.77, -0.78] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@gjulianm gjulianm added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Feb 11, 2025
@gjulianm gjulianm force-pushed the guillermo.julian/select-fatbin-archs branch from 56b804b to 3bbe1a9 Compare February 11, 2025 13:38
@gjulianm gjulianm marked this pull request as ready for review February 11, 2025 15:28
@gjulianm gjulianm requested a review from a team as a code owner February 11, 2025 15:28
@gjulianm gjulianm added the ask-review Ask required teams to review this PR label Feb 11, 2025
Copy link
Contributor

@val06 val06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

pkg/gpu/context.go Outdated Show resolved Hide resolved
@gjulianm
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 11, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-11 17:58:08 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.


2025-02-11 18:39:29 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 17a4cbf into main Feb 11, 2025
305 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guillermo.julian/select-fatbin-archs branch February 11, 2025 18:39
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants