[CWS] optimization to socket bound snapshotting

[paulcacheux]

What does this PR do?

pprof

This PR optimizes the way we collect bound sockets, reducing the amount of allocation related to parsing /proc. Some profiles showed that this code path could allocate a lot more than expected pprof.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 55721759 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor a8298d389bf6239cd3a13a7c07486ea4307c4433

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	865.67MB	865.67MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	875.43MB	875.43MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	875.43MB	875.43MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	854.18MB	854.18MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	863.93MB	863.93MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	41.57MB	41.57MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	41.64MB	41.64MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	41.64MB	41.64MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	39.83MB	39.83MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	441.05MB	441.05MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	61.75MB	61.75MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	61.82MB	61.82MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	61.82MB	61.82MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.01MB	59.01MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.08MB	59.08MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55721759 --os-family=ubuntu

Note: This applies to commit 467f53f

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	837.51MiB	847.49MiB	202.85MiB	212.83MiB
✅	static_quality_gate_docker_agent_amd64	921.72MiB	931.7MiB	308.65MiB	318.67MiB
✅	static_quality_gate_docker_agent_arm64	934.09MiB	944.08MiB	292.66MiB	303.0MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.09GiB	1.11GiB	383.79MiB	393.75MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.09GiB	1.11GiB	363.74MiB	373.71MiB
✅	static_quality_gate_docker_dogstatsd_amd64	47.86MiB	57.88MiB	18.29MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	46.26MiB	56.27MiB	17.05MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	267.75MiB	277.7MiB	107.3MiB	117.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	283.79MiB	293.73MiB	102.15MiB	112.12MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e0c73cd7-0d16-4c59-a6e2-a4fe722ff0e3

Baseline: a8298d3
Comparison: 467f53f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_tree	memory utilization	+0.89	[+0.83, +0.95]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.30	[-0.16, +0.77]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.07	[-0.84, +0.98]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.04	[-0.88, +0.96]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.90, +0.94]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.01	[-0.62, +0.65]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.96, +0.98]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.00	[-0.73, +0.72]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.28, +0.26]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.05	[-0.84, +0.74]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.25	[-0.31, -0.19]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.36	[-1.13, +0.41]	1	Logs
➖	quality_gate_idle	memory utilization	-0.42	[-0.46, -0.37]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.83	[-0.89, -0.76]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.58	[-5.59, +0.43]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[paulcacheux]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.
2025-02-12 20:07:25 UTC ℹ️ Start processing command /merge

---

2025-02-12 20:07:29 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 32m.

---

2025-02-12 20:49:39 UTC ℹ️ MergeQueue: This merge request was merged