Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test. #33984

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix flaky test. #33984

merged 1 commit into from
Feb 12, 2025

Conversation

dplepage-dd
Copy link
Contributor

What does this PR do?

Fixes a flaky test (the order in which the profiles are checked is arbitrary, so the error message is sometimes that profile2 conflicts with profile1, and sometimes that profile1 conflicts with profile2).

@dplepage-dd dplepage-dd requested a review from a team as a code owner February 12, 2025 14:18
@dplepage-dd dplepage-dd requested a review from TCheruy February 12, 2025 14:18
@dplepage-dd
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 12, 2025

View all feedbacks in Devflow UI.
2025-02-12 14:19:08 UTC ℹ️ Start processing command /merge


2025-02-12 14:19:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-12 15:07:12 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 30m.


2025-02-12 16:33:56 UTC ℹ️ MergeQueue: This merge request was merged

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 12, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor fc1ab966e32e59e23ab70f376c3287defd3093af

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 865.65MB 865.65MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 875.41MB 875.41MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 875.41MB 875.41MB 0.50MB
datadog-agent-arm64-deb 0.00MB 854.16MB 854.16MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 863.91MB 863.91MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.04MB 59.04MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.53MB 56.53MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 441.05MB 441.05MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.41MB 86.41MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.47MB 86.47MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.47MB 86.47MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.68MB 82.68MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.75MB 82.75MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 836.89MiB 847.49MiB 202.83MiB 212.83MiB
static_quality_gate_docker_agent_amd64 921.7MiB 931.7MiB 308.67MiB 318.67MiB
static_quality_gate_docker_agent_arm64 934.08MiB 944.08MiB 292.66MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.75MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.71MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.25MiB 56.27MiB 17.04MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.75MiB 277.7MiB 107.3MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.79MiB 293.73MiB 102.15MiB 112.12MiB

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55674645 --os-family=ubuntu

Note: This applies to commit 4ab4c29

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e5d27398-aa61-4480-bf26-ac87de8b8a76

Baseline: fc1ab96
Comparison: 4ab4c29
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.04 [+0.10, +1.98] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.30 [+0.23, +0.36] 1 Logs
quality_gate_idle_all_features memory utilization +0.13 [+0.07, +0.19] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.06 [-0.71, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.05 [-0.89, +0.99] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.02 [-0.62, +0.66] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.27, +0.27] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.71, +0.71] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.87, +0.87] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.00 [-0.79, +0.78] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.02] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.85, +0.80] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.11 [-0.58, +0.36] 1 Logs
quality_gate_logs % cpu utilization -0.33 [-3.37, +2.71] 1 Logs
file_tree memory utilization -0.50 [-0.56, -0.44] 1 Logs
quality_gate_idle memory utilization -0.85 [-0.89, -0.81] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit a8298d3 into main Feb 12, 2025
255 of 257 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dpl/fix-flaky-test branch February 12, 2025 16:33
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/network-device-monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants