Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "[EBPF] gpu: introduce lazy ELF section reader (#33902)" (#33995) #34007

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

gjulianm
Copy link
Contributor

@gjulianm gjulianm commented Feb 13, 2025

What does this PR do?

Reapply a PR that was reverted due to the new-e2e-windows-systemprobe: [--run TestVMSuite] breaking on main.

Motivation

#incident-35081

Describe how you validated your changes

CI should pass with all E2E tests enabled.

Possible Drawbacks / Trade-offs

Additional Notes

@gjulianm gjulianm self-assigned this Feb 13, 2025
@github-actions github-actions bot added team/ebpf-platform medium review PR review might take time labels Feb 13, 2025
@gjulianm gjulianm added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog labels Feb 13, 2025
@gjulianm
Copy link
Contributor Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 09:18:09 UTC ℹ️ Start processing command /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on


2025-02-13 09:18:49 UTC ℹ️ Gitlab pipeline started

Started pipeline #55781302

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 13, 2025

Uncompressed package size comparison

Comparison with ancestor b62cc23d7a61f8cbe7c2c5d8db294f17e9837a8e

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.02MB ⚠️ 864.17MB 864.15MB 0.50MB
datadog-agent-amd64-deb 0.02MB ⚠️ 865.93MB 865.91MB 0.50MB
datadog-agent-arm64-deb 0.02MB ⚠️ 854.42MB 854.41MB 0.50MB
datadog-agent-x86_64-rpm 0.02MB ⚠️ 875.69MB 875.68MB 0.50MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 875.69MB 875.68MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 41.57MB 41.57MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 41.65MB 41.65MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 41.65MB 41.65MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 39.83MB 39.83MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 441.05MB 441.05MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 61.76MB 61.76MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 61.83MB 61.83MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 61.83MB 61.83MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.08MB 59.08MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 13, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55791635 --os-family=ubuntu

Note: This applies to commit 9efcbab

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 13, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 837.68MiB 847.49MiB 202.72MiB 212.83MiB
static_quality_gate_docker_agent_amd64 921.97MiB 931.7MiB 308.77MiB 318.67MiB
static_quality_gate_docker_agent_arm64 934.32MiB 944.08MiB 292.76MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.86MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.81MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.3MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.25MiB 56.27MiB 17.04MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.76MiB 277.7MiB 107.29MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.81MiB 293.73MiB 102.14MiB 112.12MiB

Copy link

cit-pr-commenter bot commented Feb 13, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 519546cc-1f44-4a72-8549-24644a57079a

Baseline: b62cc23
Comparison: 9efcbab
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.62 [-0.50, +5.73] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.40 [+0.45, +2.35] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.01 [+0.93, +1.09] 1 Logs
quality_gate_idle memory utilization +0.37 [+0.33, +0.41] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.22 [-0.24, +0.68] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.09 [-0.67, +0.85] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.74, +0.83] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.93, +0.97] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.03] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.63, +0.63] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.30, +0.28] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.95, +0.92] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.87, +0.80] 1 Logs
file_tree memory utilization -0.15 [-0.21, -0.08] 1 Logs
quality_gate_idle_all_features memory utilization -0.89 [-0.95, -0.84] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -1.08 [-1.89, -0.27] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 55791635 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@gjulianm gjulianm marked this pull request as ready for review February 13, 2025 11:30
@gjulianm gjulianm requested a review from a team as a code owner February 13, 2025 11:30
@gjulianm gjulianm added the ask-review Ask required teams to review this PR label Feb 13, 2025
Copy link
Contributor

@val06 val06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would consider putting elf.go under a go build:linux flag

@gjulianm
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 15:30:54 UTC ℹ️ Start processing command /merge


2025-02-13 15:31:01 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 33m.


2025-02-13 16:26:54 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3543ef8 into main Feb 13, 2025
318 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guillermo.julian/reapply-elf-parser branch February 13, 2025 16:26
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-review Ask required teams to review this PR changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants