Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workloadmeta/catalog-core] Remove kubeapiserver #34014

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

davidor
Copy link
Member

@davidor davidor commented Feb 13, 2025

What does this PR do?

Small cleanup in the workloadmeta catalog used by the core agent.

This PR removes the kubeapiserver collector from the workloadmeta catalog used by the Core Agent.

The collector is only relevant for the Cluster Agent, and while it was previously imported, it was never actually running because its attributes specify that it is only for the Cluster Agent.

This change is purely for clarity. The collector did not introduce any additional dependencies beyond those already required elsewhere in the code, so there is no impact on binary size.

Describe how you validated your changes

Covered by tests.

@davidor davidor added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/container-platform The Container Platform Team labels Feb 13, 2025
@davidor davidor added this to the 7.64.0 milestone Feb 13, 2025
@davidor davidor requested a review from a team as a code owner February 13, 2025 11:37
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 13, 2025
@davidor
Copy link
Member Author

davidor commented Feb 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 11:58:34 UTC ℹ️ Start processing command /merge


2025-02-13 11:58:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-13 12:26:09 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 33m.


2025-02-13 13:07:18 UTC ℹ️ MergeQueue: This merge request was merged

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 73d6da91ece452765883396ea096841bce183324

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 865.91MB 865.91MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 875.68MB 875.68MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 875.68MB 875.68MB 0.50MB
datadog-agent-arm64-deb 0.00MB 854.41MB 854.41MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 864.16MB 864.16MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 41.57MB 41.57MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 41.65MB 41.65MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 41.65MB 41.65MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 39.83MB 39.83MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 441.05MB 441.05MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 61.76MB 61.76MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 61.83MB 61.83MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 61.83MB 61.83MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.08MB 59.08MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55798970 --os-family=ubuntu

Note: This applies to commit b5da7ae

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 837.65MiB 847.49MiB 202.74MiB 212.83MiB
static_quality_gate_agent_deb_arm64 826.52MiB 858.45MiB 182.46MiB 214.3MiB
static_quality_gate_agent_rpm_amd64 837.6MiB 858.45MiB 206.18MiB 214.3MiB
static_quality_gate_agent_rpm_arm64 826.57MiB 858.45MiB 184.43MiB 214.3MiB
static_quality_gate_agent_suse_amd64 837.64MiB 858.45MiB 206.18MiB 214.3MiB
static_quality_gate_agent_suse_arm64 826.56MiB 858.45MiB 184.43MiB 214.3MiB
static_quality_gate_dogstatsd_deb_amd64 39.72MiB 858.45MiB 10.57MiB 214.3MiB
static_quality_gate_dogstatsd_deb_arm64 38.06MiB 858.45MiB 9.14MiB 214.3MiB
static_quality_gate_dogstatsd_rpm_amd64 39.72MiB 858.45MiB 10.58MiB 214.3MiB
static_quality_gate_dogstatsd_suse_amd64 39.72MiB 858.45MiB 10.58MiB 214.3MiB
static_quality_gate_iot_agent_deb_amd64 58.97MiB 858.45MiB 14.82MiB 214.3MiB
static_quality_gate_iot_agent_deb_arm64 56.35MiB 858.45MiB 12.79MiB 214.3MiB
static_quality_gate_iot_agent_rpm_amd64 58.97MiB 858.45MiB 14.84MiB 214.3MiB
static_quality_gate_iot_agent_rpm_arm64 56.35MiB 858.45MiB 12.8MiB 214.3MiB
static_quality_gate_iot_agent_suse_amd64 58.97MiB 858.45MiB 14.84MiB 214.3MiB
static_quality_gate_docker_agent_amd64 921.96MiB 931.7MiB 308.75MiB 318.67MiB
static_quality_gate_docker_agent_arm64 934.31MiB 944.08MiB 292.75MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.88MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.82MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.26MiB 56.27MiB 17.04MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.76MiB 277.7MiB 107.29MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.79MiB 293.73MiB 102.15MiB 112.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c7692d84-3b63-4901-8763-8629e32b4f16

Baseline: 73d6da9
Comparison: b5da7ae
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.13 [+0.22, +2.04] 1 Logs
quality_gate_idle memory utilization +0.75 [+0.71, +0.78] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.15 [+0.10, +0.20] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.13 [+0.06, +0.20] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.89, +0.93] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.30] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.65, +0.65] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.86, +0.83] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.80, +0.77] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.66, +0.62] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.09 [-0.96, +0.78] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.20 [-1.00, +0.61] 1 Logs
file_tree memory utilization -0.36 [-0.43, -0.30] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.37 [-0.84, +0.10] 1 Logs
quality_gate_logs % cpu utilization -1.39 [-4.46, +1.69] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit b55346b into main Feb 13, 2025
262 of 271 checks passed
@dd-mergequeue dd-mergequeue bot deleted the davidor/clean-workloadmeta-catalog-core-agent branch February 13, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants