[cmd/security-agent/main_windows] Use remote workloadmeta catalog

[davidor]

What does this PR do?

This PR changes the workloadmeta collector catalog used by the security-agent on windows. Before it was using the one that includes all the collectors, but in should use the remote catalog instead.

The linux version is already using the remote catalog, plus the windows one already specifies that it wants to use "remote" here:

datadog-agent/cmd/security-agent/main_windows.go

Line 127 in dee20b3

AgentType: workloadmeta.Remote,

so the change shouldn't affect functionality, but it's going to remove unnecessary collector imports.

Describe how you validated your changes

I don't think we need specific tests for this one, but I'll leave it to the agent-security team to decide.

[cit-pr-commenter]

Go Package Import Differences

Baseline: 706ca4f
Comparison: 7415ea6

binary	os	arch	change
security-agent	windows	amd64	+0, -17 -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/catalog -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/cloudfoundry/container -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/cloudfoundry/vm -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/containerd -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/crio -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/docker -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/ecs -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/ecsfargate -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/kubeapiserver -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/kubelet -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/kubemetadata -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/nvml -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/podman -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/internal/remote/processcollector -github.com/DataDog/datadog-agent/comp/core/workloadmeta/collectors/util -github.com/DataDog/datadog-agent/internal/third_party/golang/expansion -github.com/DataDog/datadog-agent/pkg/util/gpu

[paulcacheux]

Good catch, Thanks !

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55832251 --os-family=ubuntu

Note: This applies to commit 7415ea6

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 706ca4fb9f36a19f54fae36ae4ad9260b263b892

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	865.90MB	865.90MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	875.66MB	875.66MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	875.66MB	875.66MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	854.39MB	854.39MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	864.14MB	864.14MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	41.57MB	41.57MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	41.64MB	41.64MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	41.64MB	41.64MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	39.83MB	39.83MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	441.04MB	441.04MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	61.75MB	61.75MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	61.82MB	61.82MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	61.82MB	61.82MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.00MB	59.00MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.08MB	59.08MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	837.71MiB	847.49MiB	202.77MiB	212.83MiB
✅	static_quality_gate_agent_deb_arm64	826.73MiB	858.45MiB	182.52MiB	214.3MiB
✅	static_quality_gate_agent_rpm_amd64	837.71MiB	858.45MiB	206.18MiB	214.3MiB
✅	static_quality_gate_agent_rpm_arm64	826.71MiB	858.45MiB	184.51MiB	214.3MiB
✅	static_quality_gate_agent_suse_amd64	837.66MiB	858.45MiB	206.18MiB	214.3MiB
✅	static_quality_gate_agent_suse_arm64	826.66MiB	858.45MiB	184.51MiB	214.3MiB
✅	static_quality_gate_dogstatsd_deb_amd64	39.72MiB	858.45MiB	10.57MiB	214.3MiB
✅	static_quality_gate_dogstatsd_deb_arm64	38.06MiB	858.45MiB	9.14MiB	214.3MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	39.72MiB	858.45MiB	10.58MiB	214.3MiB
✅	static_quality_gate_dogstatsd_suse_amd64	39.72MiB	858.45MiB	10.58MiB	214.3MiB
✅	static_quality_gate_iot_agent_deb_amd64	58.96MiB	858.45MiB	14.82MiB	214.3MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.35MiB	858.45MiB	12.8MiB	214.3MiB
✅	static_quality_gate_iot_agent_rpm_amd64	58.96MiB	858.45MiB	14.83MiB	214.3MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.35MiB	858.45MiB	12.8MiB	214.3MiB
✅	static_quality_gate_iot_agent_suse_amd64	58.96MiB	858.45MiB	14.83MiB	214.3MiB
✅	static_quality_gate_docker_agent_amd64	921.94MiB	931.7MiB	308.74MiB	318.67MiB
✅	static_quality_gate_docker_agent_arm64	934.3MiB	944.08MiB	292.75MiB	303.0MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.09GiB	1.1GiB	383.87MiB	393.75MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.09GiB	1.1GiB	363.82MiB	373.71MiB
✅	static_quality_gate_docker_dogstatsd_amd64	47.86MiB	57.88MiB	18.3MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	46.25MiB	56.27MiB	17.05MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	267.76MiB	277.7MiB	107.31MiB	117.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	283.8MiB	293.73MiB	102.14MiB	112.12MiB

[davidor]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.
2025-02-13 16:25:29 UTC ℹ️ Start processing command /merge

---

2025-02-13 16:25:43 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2025-02-13 16:30:22 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 33m.

---

2025-02-13 16:37:34 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.

---

2025-02-13 16:40:56 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.

---

2025-02-13 17:08:12 UTC ℹ️ MergeQueue: This merge request was merged

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: dbe4aa8c-4ca5-4983-80b3-a60d90b0874c

Baseline: 706ca4f
Comparison: 7415ea6
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.04	[-0.43, +0.50]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.25, +0.29]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.01, +0.03]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.01	[-0.63, +0.64]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.00	[-0.82, +0.82]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.00	[-0.87, +0.87]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.80, +0.77]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.03	[-0.79, +0.73]	1	Logs
➖	file_tree	memory utilization	-0.04	[-0.11, +0.03]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.07	[-0.98, +0.84]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.11	[-0.17, -0.06]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-0.11	[-3.20, +2.97]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.41	[-1.19, +0.37]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.49	[-1.39, +0.41]	1	Logs
➖	quality_gate_idle	memory utilization	-0.85	[-0.90, -0.80]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-1.10	[-1.18, -1.03]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.