Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pyyaml] Fix create-regex-at-runtime patch #5115

Merged
merged 1 commit into from
Mar 13, 2020
Merged

[pyyaml] Fix create-regex-at-runtime patch #5115

merged 1 commit into from
Mar 13, 2020

Conversation

KSerrania
Copy link
Contributor

What does this PR do?

Fix the patch diff following this change in the upstream repo, which was added in 5.3.

Motivation

Fix Agent pipelines, make integrations build work.

@KSerrania KSerrania added this to the 7.19.0 milestone Mar 13, 2020
@KSerrania KSerrania requested a review from a team as a code owner March 13, 2020 12:17
albertvaka
albertvaka reviewed Mar 13, 2020
View reviewed changes
Copy link
Contributor

@albertvaka albertvaka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance this patch can go away/get upstreamed?

Edit: I guess not for python 2.

@AlexandreYang
Copy link
Member

AlexandreYang commented Mar 13, 2020 •
edited
Loading

The PR already a PR yaml/pyyaml#301 (cc @therve ). From discussion history it was scheduled for 5.3, but it's now back to Backlog.

@KSerrania KSerrania merged commit 5e4c465 into master Mar 13, 2020
@KSerrania KSerrania deleted the kserrania/fix-yaml-patch branch March 13, 2020 13:34
@olivielpeau olivielpeau mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvaka albertvaka albertvaka approved these changes

@AlexandreYang AlexandreYang AlexandreYang approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog [deprecated] team/agent-platform team/integrations
Projects
None yet
Milestone
7.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@KSerrania @AlexandreYang @albertvaka