Improve tagger #586
Merged
Improve tagger #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
hush-hush
force-pushed
the
maxivello/improve-tagger
branch
from
2ca32a1 to
23beec8
Compare
masci
added
component/collector
[deprecated] team/agent-core
hkaj
previously approved these changes
Sep 20, 2017
| # | ||
| # We can extract container label or environment variables | ||
| # as metric tags. If you prefix your tag name with +, it | ||
| # will only be added to high cardinality metrics (docker check) |
There was a problem hiding this comment.
nothing to change here, just a thought: we'll need to document the high cardinality very well and carefully once it's better defined
hush-hush
force-pushed
the
maxivello/improve-tagger
branch
from
633a288 to
9b467d2
Compare
masci
approved these changes
Sep 20, 2017
| // NeedInit returns true if InitDockerUtil has to be called | ||
| // before using the package | ||
| func NeedInit() bool { | ||
| if globalDockerUtil == nil { |
There was a problem hiding this comment.
I would return globalDockerUtil == nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add docker tags to the tagger.
Motivation
This is needed to build a docker check.
Additional Notes
This is based on #585, you can skip the
pkg/utilfolder from your review.