Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Report correct architecture for Mac M1 chip #7568

Merged
merged 3 commits into from
Mar 3, 2021
Merged

[macOS] Report correct architecture for Mac M1 chip #7568

merged 3 commits into from
Mar 3, 2021

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 3, 2021 •
edited
Loading

What does this PR do?

Motivation

Additional Notes

  • The processor name will still be reported incorrectly (it will display as Virtual Apple) but there is not much we can do about this.

Describe your test plan

  • Install the Datadog Agent and check that the reported "processor" and "machine" fields are arm and arm64 respectively. The GOARCH value will still be amd64 since the Agent is an amd64 binary.

@mx-psi mx-psi added this to the 7.27.0 milestone Mar 3, 2021
@mx-psi mx-psi marked this pull request as ready for review March 3, 2021 12:31
@mx-psi mx-psi requested a review from a team March 3, 2021 12:31
@mx-psi mx-psi merged commit 94b7f2d into master Mar 3, 2021
@mx-psi mx-psi deleted the mx-psi/bump-gohai branch March 3, 2021 12:40
@mx-psi mx-psi mentioned this pull request Mar 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvaka albertvaka albertvaka approved these changes

Assignees
No one assigned
Labels
[deprecated] team/agent-platform
Projects
None yet
Milestone
7.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mx-psi @albertvaka