Add tests for cloud ints #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
reviewed
Nov 25, 2019
jirikuncar
reviewed
Nov 25, 2019
jirikuncar
reviewed
Nov 25, 2019
jirikuncar
reviewed
Nov 25, 2019
jirikuncar
reviewed
Nov 25, 2019
jirikuncar
reviewed
Nov 25, 2019
jirikuncar
reviewed
Nov 25, 2019
Co-Authored-By: Jiri Kuncar <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…og-api-client-go into ricky/add_cloud_ints_tests
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nmuesch
requested changes
Dec 16, 2019
There was a problem hiding this comment.
Thanks for this. Left some comments but should be good after that.
Mostly
- Lets check for errors + httpResp codes anytime we call an endpoint
- We should defer the uninstallation of any updated accounts being created
- Lets use the account variables in the assertions being done instead of the hardcoded values.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
1 similar comment
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jirikuncar
suggested changes
Dec 17, 2019
|
|
||
| var UNIQUEACCOUNTID = fmt.Sprintf("12345%s", time.Now()) | ||
|
|
||
| var TESTAWSACCLOGS = datadog.AwsAccount{ |
There was a problem hiding this comment.
we should create a factory function so each testcase creates it's unique AwsAccount, AwsAccountAndLambdaInput and AwsLogsServicesInput.
There was a problem hiding this comment.
Good call, I added a quick commit to add this. (talked to @Ricky-Thomas offline)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jirikuncar
reviewed
Dec 17, 2019
| list_output_2, _, _ := TESTAPICLIENT.AWSLogsIntegrationApi.AWSLogsList(TESTAUTH) | ||
|
|
||
| var list_of_arns_2 []datadog.AwsLogsListOutputLambdas | ||
| x = false |
There was a problem hiding this comment.
Suggested change
| x = false | |
| existsAfterDelete = false |
jirikuncar
reviewed
Dec 17, 2019
| } | ||
| } | ||
| // Check that ARN no longer exists after delete | ||
| assert.Assert(t, x != true) |
There was a problem hiding this comment.
Suggested change
| assert.Assert(t, x != true) | |
| assert.Assert(t, !existsAfterDelete) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required test suite for generate Go client.
Also randomized certain credentials in each test file to ensure test idempotency.