[K9VULN-2465] Add validation of package names

[juli1]

What problem are you trying to solve?

Clients are sending us package names for Python with invalid characters. We want to start filtering these names. They are filtered in the API.

Solution

Warn the user about invalid package names for Python. This is not removing for the payload as this is done by the API. It warns the user about a malformed payload.

Testing

Added units tests

Tried locally with a SBOM and a library containing the name cloud picke (with a space).

[datadog-datadog-prod-us1]

Datadog Report

Branch report: juli1/K9VULN-2465
Commit report: b5a6958
Test service: datadog-ci-tests

✅ 0 Failed, 420 Passed, 0 Skipped, 1m 51.7s Total duration (1m 58.8s time saved)

[dastrong]

Left one code suggestion that I think we should make, but won't block on it.

[dastrong]

Suggested change

	const pythonPackaNameRegex = new RegExp('^[a-zA-Z0-9][a-zA-Z0-9\\-_.]*[a-zA-Z0-9]$')
	export const validateDependencyName = (dependency: Dependency): boolean => {
	if (dependency.language === DependencyLanguage.PYTHON && !pythonPackaNameRegex.test(dependency.name)) {
	const pythonPackageNameRegex = new RegExp('^[a-zA-Z0-9][a-zA-Z0-9\\-_.]*[a-zA-Z0-9]$')
	export const validateDependencyName = (dependency: Dependency): boolean => {
	if (dependency.language === DependencyLanguage.PYTHON && !pythonPackageNameRegex.test(dependency.name)) {

[dastrong]

Could we prettify this information similar to what we do in renderMissingTags, so it's easier to notice for end-users?

Suggested change

	export const renderPayloadWarning = (dependencies: Dependency[]): string => {
	let ret = ''
	for (const dep of dependencies) {
	if (!validateDependencyName(dep)) {
	ret += `invalid dependency name ${dep.name}\n`
	}
	}
	return ret
	}
	export const renderPayloadWarning = (dependencies: Dependency[]): string => {
	const errors = []
	for (const dep of dependencies) {
	if (!validateDependencyName(dep)) {
	errors.push(chalk.red(` - invalid dependency name ${dep.name}\n`))
	}
	}
	if (errors.length === 0) {
	return ''
	}
	let baseHeading = 'The following issues were detected:\n'
	return baseHeading += errors.join('')
	}