Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix release script for renamed master to main #113

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Dec 7, 2023

What does this PR do?

Our release script won't work right now because we renamed the master branch to main, but the script still expects master to be the primary branch.

Motivation

I'd like to release this library.

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@astuyve astuyve requested a review from a team as a code owner December 7, 2023 20:37
@astuyve astuyve changed the title feat: Rename master to main feat: Fix release script for renamed master to main Dec 7, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@8777e57). Click here to learn what that means.

❗ Current head 94e1b53 differs from pull request most recent head c059792. Consider uploading reports for the commit c059792 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage        ?   86.43%           
=======================================
  Files           ?        8           
  Lines           ?      612           
  Branches        ?      153           
=======================================
  Hits            ?      529           
  Misses          ?       72           
  Partials        ?       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astuyve astuyve merged commit 962d66c into main Dec 7, 2023
14 checks passed
@astuyve astuyve deleted the aj/fix-release-script branch December 7, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants