Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace hub with gh cli #114

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Dec 7, 2023

What does this PR do?

hub requires personal access tokens, which we shouldn't use anymore. It's also a community project.

We can do the exact same thing with the gh command line tool https://cli.github.com/

this is a drop in replacement and was used to release 0.9.0

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@astuyve astuyve requested a review from a team as a code owner December 7, 2023 21:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac51d24) 86.43% compared to head (81e2ead) 86.43%.

❗ Current head 81e2ead differs from pull request most recent head 6dce3b9. Consider uploading reports for the commit 6dce3b9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files           8        8           
  Lines         612      612           
  Branches      153      153           
=======================================
  Hits          529      529           
  Misses         72       72           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astuyve astuyve merged commit a45b80c into main Dec 7, 2023
15 checks passed
@astuyve astuyve deleted the aj/replace-hub-with-github-cli branch December 7, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants