Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Support for Java and .NET #117

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

duncanpharvey
Copy link
Contributor

@duncanpharvey duncanpharvey commented Jan 10, 2024

What does this PR do?

Adds support for the following runtimes:

  • dotnet6
  • java11
  • java17
  • java21
  • java8
  • java8.al2

Motivation

https://datadoghq.atlassian.net/browse/SVLS-4261

Testing Guidelines

  • Unit tests to validate each runtime version is matched to the correct runtime and architecture
  • Unit tests to validate select runtimes use the correct layer
  • Deployed a Hello World Lambda function with the updated macro for each of the new runtimes supported
    • Validated the correct layer was added for .NET and Java versions and that metrics, logs, and traces are sent to Datadog on invocation (no traces for Java 8, Java8al2)
    • Validated the correct layer was added for select Python and Node.js versions and that metrics, logs, and traces are sent to Datadog on invocation

Additional Notes

Minor refactoring so the mapping between runtime + architecture and layers is more explicit.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@duncanpharvey duncanpharvey requested a review from a team as a code owner January 10, 2024 21:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (05e74a1) 86.43% compared to head (f5d6b21) 84.62%.
Report is 1 commits behind head on main.

❗ Current head f5d6b21 differs from pull request most recent head a4efeb6. Consider uploading reports for the commit a4efeb6 to get more accurate results

Files Patch % Lines
serverless/src/redirect.ts 20.00% 7 Missing and 1 partial ⚠️
serverless/src/layer.ts 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   86.43%   84.62%   -1.82%     
==========================================
  Files           8        8              
  Lines         612      631      +19     
  Branches      153      158       +5     
==========================================
+ Hits          529      534       +5     
- Misses         72       85      +13     
- Partials       11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duncanpharvey duncanpharvey marked this pull request as draft January 10, 2024 21:27
@duncanpharvey duncanpharvey marked this pull request as ready for review January 11, 2024 15:53
@duncanpharvey duncanpharvey requested a review from a team as a code owner January 11, 2024 15:53
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – just curious about why it doesn't work for Java 8...

@duncanpharvey duncanpharvey merged commit bb978bb into main Jan 12, 2024
13 checks passed
@duncanpharvey duncanpharvey deleted the duncan-harvey/additional-runtime-support branch January 12, 2024 16:22
@duncanpharvey duncanpharvey changed the title Add Support for Java and .NET feat: Add Support for Java and .NET Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants