Allow the extension layer to be applied separately from the runtime layers #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serverless/src/layer.ts
Outdated
| export function applyExtensionLayer(region: string, lambdas: LambdaFunction[], extensionLayerVersion?: number) { | ||
| const errors: string[] = []; | ||
| lambdas.forEach((lambda) => { | ||
| let lambdaExtensionLayerArn; | ||
|
|
||
| if (extensionLayerVersion !== undefined) { |
There was a problem hiding this comment.
I feel like we should do here similarly to what we do above. If the extension version is not set, return an error. Otherwise, I think it will be real confusing for people.
There was a problem hiding this comment.
I have added this functionality and tested it.
purple4reina
requested changes
Sep 13, 2024
…bumping major version
purple4reina
approved these changes
Sep 17, 2024
|
extensionLayerVersion has always been optional as you don't need it if you are pushing your logs to cloudwatch and then using the cloudwatch forwarder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently there is no way to deploy with the cloudformation macro and only apply the extension.
This PR adds this ability when the user sets
addLayerstofalsethe extension will still be applied.To override this feature a new configuration option has been made called 'addExtension
. This defaults totrue` ensuring the extension layer is applied.Motivation
Currently if a customer is providing their own lambda libraries (dd-trace, datadog-lambda-js) there is no way to exclude these layers from the deployment and still retain the extension layer. This adds that functionality for this edge case.
Testing Guidelines
In addition to the unit tests i used the release tool to upload my changes to a staging bucket that hosted the macro. Which i deployed to a sandbox aws environment and then created a new function using the macro. I had set
addLayerstofalsealong with leavingaddExtensionto default. This produced a lambda with just the extension layer.I then modified my template.yaml file to set
addExtensiontofalsethis resulted in no lambda's being added.Additional Notes
I did not increment the version number in the template yaml file.
One thing to consider is that users that have
addLayerstofalsetoday and redeploy the macro will see a change in the expected behavior.Types of changes
Check all that apply