Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Loosen the check in the test
env.spec.ts
so it can pass on my machine.Before, the tests require that the params fetched by
getConfigFromCfnParams()
exactly match the expected dict. I changed it to require the params fetched be a superset of the expected dict.Motivation
When I run
npm test
on my machine, a few tests inenv.spec.ts
fail because the config retrieved has some extra fields than expected, such asapiKey
. This is just because I haveDD_API_KEY
set on my machine usingexport DD_API_KEY=xxx
, and probably it was not set on the test author's machine when she wrote this test. I think we should loosen the check so this difference won't be treated as a failure.Testing Guidelines
Run
npm test
. The tests changed from failing to passing.Additional Notes
Types of changes
Check all that apply